Re: [PATCH] branding-mcsdk: Adding MCSDK branding include file

From: Denys Dmytriyenko <denys@ti.com>
To: "Cooper Jr., Franklin" <fcooper@ti.com>
Cc: "meta-arago@arago-project.org" <meta-arago@arago-project.org>
Subject: Re: [PATCH] branding-mcsdk: Adding MCSDK branding include file
Date: Fri, 6 Feb 2015 15:42:43 -0500	[thread overview]
Message-ID: <20150206204243.GD12366@edge> (raw)
In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C7FB1BB@DFLE08.ent.ti.com>

On Fri, Feb 06, 2015 at 03:32:42PM -0500, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > bounces@arago-project.org] On Behalf Of Nelson, Sam
> > Sent: Friday, February 06, 2015 1:51 PM
> > To: Dmytriyenko, Denys
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] branding-mcsdk: Adding MCSDK branding
> > include file
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: Dmytriyenko, Denys
> > > Sent: Friday, February 06, 2015 2:00 PM
> > > To: Nelson, Sam
> > > Cc: meta-arago@arago-project.org
> > > Subject: Re: [meta-arago] [PATCH] branding-mcsdk: Adding MCSDK
> > > branding include file
> > >
> > > On Fri, Feb 06, 2015 at 01:54:56PM -0500, Sam Nelson wrote:
> > > > - To control preferred version and providers for MCSDK
> > > >
> > > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > > ---
> > > >  .../conf/distro/include/branding-mcsdk.inc         |   20
> > > ++++++++++++++++++++
> > > >  1 file changed, 20 insertions(+)
> > > >  create mode 100644 meta-arago-distro/conf/distro/include/branding-
> > > mcsdk.inc
> > > >
> > > > diff --git
> > > > a/meta-arago-distro/conf/distro/include/branding-mcsdk.inc
> > > b/meta-arago-distro/conf/distro/include/branding-mcsdk.inc
> > > > new file mode 100644
> > > > index 0000000..d023b67
> > > > --- /dev/null
> > > > +++ b/meta-arago-distro/conf/distro/include/branding-mcsdk.inc
> > > > @@ -0,0 +1,20 @@
> > > > +# MCSDK branding configuration
> > > > +
> > > > +# Use the MCSDK supported versions
> > > > +PREFERRED_VERSION_libnl = "3.2.24"
> > > > +
> > > > +DISTRO_FEATURES += "x11 opengl"
> > >
> > > I assume x11 is to make Java happy? I don't think you have x11 env...
> > >
> > [Sam] Yes it was to make Java happy.
> [Franklin] I thought I remembered that the mcsdk were meant for headless devices.
> If so I would recommend taking a look at the discussion here:
> https://github.com/woglinde/meta-java/issues/45
> 
> Pulling in x11 and gtk seems painful especially since you're not using it.
> Anyway it's something to look into if it is indeed meant for headless devices.
> But its ur branding file so my above comments aren't meant to block this patch from being accepted.

Well, as explained in that tracker link you provided, pulling X libs for the 
build doesn't necessary mean you'll end up with X component on the target. 
Yes, disabling AWT is a nice touch, hopefully it gets integrated into meta-java

> > > > +# Java preferences.
> > > > +#PREFERRED_VERSION_openjdk-7-jre = "25b30-2.3.12"
> > > > +PREFERRED_VERSION_icedtea7-native = "2.1.3"
> > > > +PREFERRED_PROVIDER_openjdk-7-jre = "openjdk-7-jre"
> > > > +
> > > > +PREFERRED_PROVIDER_virtual/java-initial = "cacao-initial"
> > > > +
> > > > +PREFERRED_PROVIDER_virtual/java-native = "jamvm-native"
> > > > +PREFERRED_PROVIDER_virtual/javac-native = "ecj-bootstrap-native"
> > > > +
> > > > +PREFERRED_PROVIDER_jpeg-native = "jpeg-native"
> > > > +#PREFERRED_PROVIDER_jpeg-native = "libjpeg-turbo-native"
> > > > +PREFERRED_PROVIDER_glibc-gconv-iso8859-1 = "nativesdk-eglibc-locale"
> > > > --
> > > > 1.7.9.5
> > > >
> > > > _______________________________________________
> > > > meta-arago mailing list
> > > > meta-arago@arago-project.org
> > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago