From: Lauri Kasanen <cand@gmx.com>
To: jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ao2@ao2.it, AndrewD207@aol.com
Subject: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers
Date: Sat, 7 Feb 2015 15:48:59 +0200 [thread overview]
Message-ID: <20150207154859.89a7e4e3.cand@gmx.com> (raw)
Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send
any events. Now everything works including the leds.
Based on work by Andrew Haines and Antonio Ospite.
cc: Antonio Ospite <ao2@ao2.it>
cc: Andrew Haines <AndrewD207@aol.com>
Signed-off-by: Lauri Kasanen <cand@gmx.com>
---
drivers/hid/hid-sony.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
Antonio's original approach was not enough; it enabled the events,
but only for a few seconds, then the controller timed out and sent
no more. Andrew's did more than was necessary. This is a combination
of the two, against Linus' git.
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 31e9d25..de93386 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -36,6 +36,7 @@
#include <linux/list.h>
#include <linux/idr.h>
#include <linux/input/mt.h>
+#include <linux/usb/input.h>
#include "hid-ids.h"
@@ -1130,8 +1131,12 @@ static void sony_input_configured(struct hid_device *hdev,
*/
static int sixaxis_set_operational_usb(struct hid_device *hdev)
{
+ struct usb_interface *intf = to_usb_interface(hdev->dev.parent);
+ struct usb_device *dev = interface_to_usbdev(intf);
int ret;
- char *buf = kmalloc(18, GFP_KERNEL);
+ char *buf = kmalloc(65, GFP_KERNEL);
+ unsigned char buf2[] = { 0x00 };
+ int transfered;
if (!buf)
return -ENOMEM;
@@ -1140,7 +1145,24 @@ static int sixaxis_set_operational_usb(struct hid_device *hdev)
HID_REQ_GET_REPORT);
if (ret < 0)
- hid_err(hdev, "can't set operational mode\n");
+ hid_err(hdev, "can't set operational mode on the control EP\n");
+
+ /*
+ * Some compatible controllers like the Speedlink Strike FX and
+ * Gasia need another query plus an USB interrupt to get operational.
+ */
+ ret = hid_hw_raw_request(hdev, 0xf5, buf, 64, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+
+ if (ret < 0)
+ hid_err(hdev, "can't set operational mode on the interrupt EP\n");
+
+ ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02),
+ buf2, sizeof(buf2),
+ &transfered, USB_CTRL_SET_TIMEOUT);
+
+ if (ret < 0)
+ hid_err(hdev, "can't set operational mode on the interrupt EP\n");
kfree(buf);
--
1.8.3.1
next reply other threads:[~2015-02-07 13:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 13:48 Lauri Kasanen [this message]
2015-02-07 15:56 ` [PATCH] HID: sony: Enable Gasia third-party PS3 controllers Benjamin Tissoires
2015-02-07 16:31 ` Antonio Ospite
2015-02-07 16:31 ` Antonio Ospite
2015-02-07 21:48 ` Lauri Kasanen
2015-03-19 10:26 ` David Herrmann
2015-02-09 10:08 ` Oliver Neukum
2015-02-09 18:44 ` Lauri Kasanen
2015-02-10 8:14 ` Oliver Neukum
2015-03-16 21:10 ` Pavel Machek
2015-03-16 21:37 ` Jiri Kosina
2015-03-19 9:14 ` Oliver Neukum
2015-03-19 9:38 ` Pavel Machek
2015-03-19 9:54 ` Oliver Neukum
2015-03-19 10:12 ` Pavel Machek
2015-03-19 10:29 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150207154859.89a7e4e3.cand@gmx.com \
--to=cand@gmx.com \
--cc=AndrewD207@aol.com \
--cc=ao2@ao2.it \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.