Re: [PATCH 0/2] GPIO joystick driver

[Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Hi Hans,

On Sat, Feb 07, 2015 at 07:35:46AM +0000, Holmberg, Hans wrote:
> Hi Dmitry,
> 
> > Why do we need this new driver when we have gpio-keys driver that can be
> > configured to emit ABS_* events?
> > 
> 
> As far as I can tell, there is no way to specify values for ABS-"keys" in the
> device tree binding. 

It may mot be present in device tree binding, but the driver does
support it, so I would rather extend the binding than have a brand new
driver.

> 
> While both the device tree binding and the gpio-keys driver could possibly be adapted to 
> support this, it makes sense to me to describe joysticks in a separate binding and keep
> the driver implementations apart.

Why? From the input core perspective there is no difference. It is just
a device that emits set of events.

> 
> In addition to this,  auto-repeat and the sys fs disable interface for individual keys 
> does not make sense for joysticks.

You do not need to use it when you describe the device (BTW autorepeat
for trigger might be a good thing).

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html