From mboxrd@z Thu Jan 1 00:00:00 1970 From: sylvain.rochet@finsecur.com (Sylvain Rochet) Date: Mon, 9 Feb 2015 11:04:04 +0100 Subject: [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp In-Reply-To: <1423472572-19824-4-git-send-email-voice.shen@atmel.com> References: <1423472572-19824-1-git-send-email-voice.shen@atmel.com> <1423472572-19824-4-git-send-email-voice.shen@atmel.com> Message-ID: <20150209100404.GA17242@gradator.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Bo, On Mon, Feb 09, 2015 at 05:02:52PM +0800, Bo Shen wrote: > Enable usb device port on at91sam9n12ek board. > > Signed-off-by: Bo Shen > --- > > arch/arm/boot/dts/at91sam9n12ek.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts > index 13bb24e..3e572e5 100644 > --- a/arch/arm/boot/dts/at91sam9n12ek.dts > +++ b/arch/arm/boot/dts/at91sam9n12ek.dts > @@ -120,6 +120,11 @@ > }; > }; > > + usb1: gadget at f803c000 { > + atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + }; > + There is an external resistor divider on PB16, acting like a pull-down (R22+R23). PB16 reset state is input, pull-up, schmitt trigger, you need to disable the pull-up in pinctrl this way: usb1: gadget at f803c000 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_board_usb1>; ? } pinctrl ? { usb1 { pinctrl_board_usb1: usb1-board { atmel,pins = ; /* PB16, no pull up and deglitch */ }; }; }; Sylvain From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylvain Rochet Subject: Re: [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp Date: Mon, 9 Feb 2015 11:04:04 +0100 Message-ID: <20150209100404.GA17242@gradator.net> References: <1423472572-19824-1-git-send-email-voice.shen@atmel.com> <1423472572-19824-4-git-send-email-voice.shen@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1423472572-19824-4-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bo Shen Cc: balbi-l0cyMroinI0@public.gmane.org, nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Bo, On Mon, Feb 09, 2015 at 05:02:52PM +0800, Bo Shen wrote: > Enable usb device port on at91sam9n12ek board. >=20 > Signed-off-by: Bo Shen > --- >=20 > arch/arm/boot/dts/at91sam9n12ek.dts | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/= at91sam9n12ek.dts > index 13bb24e..3e572e5 100644 > --- a/arch/arm/boot/dts/at91sam9n12ek.dts > +++ b/arch/arm/boot/dts/at91sam9n12ek.dts > @@ -120,6 +120,11 @@ > }; > }; > =20 > + usb1: gadget@f803c000 { > + atmel,vbus-gpio =3D <&pioB 16 GPIO_ACTIVE_HIGH>; > + status =3D "okay"; > + }; > + There is an external resistor divider on PB16, acting like a pull-down=20 (R22+R23). PB16 reset state is input, pull-up, schmitt trigger, you nee= d=20 to disable the pull-up in pinctrl this way: usb1: gadget@f803c000 { pinctrl-names =3D "default"; pinctrl-0 =3D <&pinctrl_board_usb1>; =E2=80=A6 } pinctrl =E2=80=A6 { usb1 { pinctrl_board_usb1: usb1-board { atmel,pins =3D = ; /* PB16, no pull up and deglitch */ }; }; }; Sylvain -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932528AbbBILNV (ORCPT ); Mon, 9 Feb 2015 06:13:21 -0500 Received: from [212.85.155.42] ([212.85.155.42]:54729 "EHLO atreides.gradator.net" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932284AbbBILNU (ORCPT ); Mon, 9 Feb 2015 06:13:20 -0500 X-Greylist: delayed 4096 seconds by postgrey-1.27 at vger.kernel.org; Mon, 09 Feb 2015 06:13:20 EST Date: Mon, 9 Feb 2015 11:04:04 +0100 From: Sylvain Rochet To: Bo Shen Cc: balbi@ti.com, nicolas.ferre@atmel.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20150209100404.GA17242@gradator.net> References: <1423472572-19824-1-git-send-email-voice.shen@atmel.com> <1423472572-19824-4-git-send-email-voice.shen@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1423472572-19824-4-git-send-email-voice.shen@atmel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: gradator@atreides.gradator.net Subject: Re: [PATCH 3/3] ARM: at91: dt: at91sam9n12ek: enable udp X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on atreides.gradator.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Bo, On Mon, Feb 09, 2015 at 05:02:52PM +0800, Bo Shen wrote: > Enable usb device port on at91sam9n12ek board. > > Signed-off-by: Bo Shen > --- > > arch/arm/boot/dts/at91sam9n12ek.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts > index 13bb24e..3e572e5 100644 > --- a/arch/arm/boot/dts/at91sam9n12ek.dts > +++ b/arch/arm/boot/dts/at91sam9n12ek.dts > @@ -120,6 +120,11 @@ > }; > }; > > + usb1: gadget@f803c000 { > + atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + }; > + There is an external resistor divider on PB16, acting like a pull-down (R22+R23). PB16 reset state is input, pull-up, schmitt trigger, you need to disable the pull-up in pinctrl this way: usb1: gadget@f803c000 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_board_usb1>; … } pinctrl … { usb1 { pinctrl_board_usb1: usb1-board { atmel,pins = ; /* PB16, no pull up and deglitch */ }; }; }; Sylvain