From: Damien Lespiau <damien.lespiau@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Mahesh Kumar <mahesh1.kumar@intel.com>
Subject: Re: [PATCH v2] drm/i915/skl: Make sure to allocate mininum sizes in the DDB
Date: Mon, 9 Feb 2015 13:59:10 +0000 [thread overview]
Message-ID: <20150209135910.GC14652@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20150209135620.GN9152@intel.com>
On Mon, Feb 09, 2015 at 03:56:20PM +0200, Ville Syrjälä wrote:
> > @@ -2544,8 +2557,9 @@ skl_allocate_pipe_ddb(struct drm_crtc *crtc,
> > * promote the expression to 64 bits to avoid overflowing, the
> > * result is < available as data_rate / total_data_rate < 1
> > */
> > - plane_blocks = div_u64((uint64_t)alloc_size * data_rate,
> > - total_data_rate);
> > + plane_blocks = minimum[plane];
> > + plane_blocks += div_u64((uint64_t)alloc_size * data_rate,
> > + total_data_rate);
>
> The minimum[] array seems pointless. The value here is always going to
> be 8.
Not in the future with new features appearing.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-09 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 9:36 [PATCH] drm/i915/skl: Add check for minimum allocable Display Data Blocks Kumar, Mahesh
2015-02-09 13:28 ` Damien Lespiau
2015-02-09 13:35 ` [PATCH v2] drm/i915/skl: Make sure to allocate mininum sizes in the DDB Damien Lespiau
2015-02-09 13:56 ` Ville Syrjälä
2015-02-09 13:59 ` Damien Lespiau [this message]
2015-02-10 4:09 ` shuang.he
2015-02-24 17:56 ` Ville Syrjälä
2015-02-24 20:42 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209135910.GC14652@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mahesh1.kumar@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.