All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Seymour, Shane M" <shane.seymour@hp.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Laurence Oberman (loberman@redhat.com)" <loberman@redhat.com>,
	"Kai.Makisara@kolumbus.fi" <Kai.Makisara@kolumbus.fi>,
	"James E.J. Bottomley (JBottomley@parallels.com)"
	<JBottomley@parallels.com>
Subject: Re: [PATCH RESEND] st implement tape statistics v3
Date: Tue, 10 Feb 2015 07:03:39 +0800	[thread overview]
Message-ID: <20150209230339.GA14070@kroah.com> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB3BF3F611@G9W0766.americas.hpqcorp.net>

Comment about your subject: the "v3" needs to go inside the []

And you need to put below the --- line what has changed from the last
version, I don't see any of my comments address here :(

On Mon, Feb 09, 2015 at 10:41:38PM +0000, Seymour, Shane M wrote:
> The following patch exposes statistics for the st driver via sysfs. There is a need for companies with large numbers of tape drives numbering in the tens of thousands to track the performance of those tape drives (e.g. when a backup exceeds its window). The statistics provided should allow the calculation of throughput, average block sizes for read and write, and time spent waiting for I/O to complete or doing tape movement.

Your keyboard has an "Enter" key, please use it around the 72nd column :)

thanks,

greg k-h

  reply	other threads:[~2015-02-09 23:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 22:41 [PATCH RESEND] st implement tape statistics v3 Seymour, Shane M
2015-02-09 23:03 ` Greg KH [this message]
2015-02-09 23:14   ` Seymour, Shane M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209230339.GA14070@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=JBottomley@parallels.com \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    --cc=shane.seymour@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.