All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Chien Yen <chien.yen@oracle.com>,
	davem@davemloft.net, rds-devel@oss.oracle.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rds: rds_cong_queue_updates needs to defer the congestion update transmission
Date: Tue, 10 Feb 2015 11:56:38 -0500	[thread overview]
Message-ID: <20150210165638.GR337@oracle.com> (raw)
In-Reply-To: <E0CB7D17-5ACB-4860-847E-BB0C01CBB65A@oracle.com>

On (02/10/15 11:50), Chuck Lever wrote:
> > 
> > This patch fixes a sock_lock deadlock in the rds_cong_queue_update path.
> 
> Note that the deadlock appears to exist only with TCP transports.
> 

True, but the patch does no harm to IB: this actually only reverts 
the change from commit 2fa57129d.

I could update the comment to note that this is only true for TCP
transports. Do you think that would help?

--Sowmini

      reply	other threads:[~2015-02-10 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 14:22 [PATCH] rds: rds_cong_queue_updates needs to defer the congestion update transmission Sowmini Varadhan
2015-02-10 16:50 ` Chuck Lever
2015-02-10 16:56   ` Sowmini Varadhan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150210165638.GR337@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=chien.yen@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.