From: Dave Jones <davej@codemonkey.org.uk>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] module: Annotate nested sleep in resolve_symbol()
Date: Tue, 10 Feb 2015 12:50:51 -0500 [thread overview]
Message-ID: <20150210175051.GA8288@codemonkey.org.uk> (raw)
In-Reply-To: <20150210171255.GQ24151@twins.programming.kicks-ass.net>
On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote:
> On which, we should probably do this.
>
> ---
> Subject: module: Replace over-engineered nested sleep
>
> Since the introduction of the nested sleep warning; we've established
> that the occasional sleep inside a wait_event() is fine.
>
> wait_event() loops are invariant wrt. spurious wakeups, and the
> occasional sleep has a similar effect on them. As long as its occasional
> its harmless.
>
> Therefore replace the 'correct' but verbose wait_woken() thing with
> a simple annotation to shut up the warning.
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Seems to suppress the warning, and modules still work.
Tested-by: Dave Jones <davej@codemonkey.org.uk>
next prev parent reply other threads:[~2015-02-10 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 16:42 3.19 scheduler might_sleep triggered from module loading during boot Dave Jones
2015-02-10 17:06 ` [PATCH] module: Annotate nested sleep in resolve_symbol() Peter Zijlstra
2015-02-10 17:12 ` Peter Zijlstra
2015-02-10 17:50 ` Dave Jones [this message]
2015-02-10 23:48 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150210175051.GA8288@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.