From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40]) by arago-project.org (Postfix) with ESMTPS id 310D052ABB for ; Tue, 10 Feb 2015 20:05:08 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id t1AK57Ik009435; Tue, 10 Feb 2015 14:05:07 -0600 Received: from DLEE71.ent.ti.com (dlee71.ent.ti.com [157.170.170.114]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id t1AK55CV025279; Tue, 10 Feb 2015 14:05:06 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE71.ent.ti.com (157.170.170.114) with Microsoft SMTP Server id 14.3.224.2; Tue, 10 Feb 2015 14:05:06 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id t1AK53du027274; Tue, 10 Feb 2015 14:05:04 -0600 Date: Tue, 10 Feb 2015 15:05:03 -0500 From: Denys Dmytriyenko To: "Nelson, Sam" Message-ID: <20150210200501.GJ13231@edge> References: <1423595959-23271-1-git-send-email-denis@denix.org> <4F9216F96E5DF9428610502835A9F4905811188E@DLEE11.ent.ti.com> MIME-Version: 1.0 In-Reply-To: <4F9216F96E5DF9428610502835A9F4905811188E@DLEE11.ent.ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: "meta-arago@arago-project.org" Subject: Re: [PATCH] arago-image, packagegroup-arago-base-tisdk: move psplash to IMAGE_FEATURES, sans server X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 20:05:08 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Tue, Feb 10, 2015 at 07:50:05PM +0000, Nelson, Sam wrote: > Is this patch based on master? I am having trouble using the patch AS IS. Ah, indeed. Fixed in v2. > See comments inline. > > > -----Original Message----- > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko > > Sent: Tuesday, February 10, 2015 2:19 PM > > To: meta-arago@arago-project.org > > Subject: [meta-arago] [PATCH] arago-image, packagegroup-arago-base-tisdk: > > move psplash to IMAGE_FEATURES, sans server > > > > From: Denys Dmytriyenko > > > > Signed-off-by: Denys Dmytriyenko > > --- > > meta-arago-distro/recipes-core/images/arago-image.inc | 2 +- > > meta-arago-distro/recipes-core/images/tisdk-server-rootfs-image.bb | 2 ++ > > .../recipes-core/packagegroups/packagegroup-arago-base-tisdk.bb | 3 +-- > > 3 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/meta-arago-distro/recipes-core/images/arago-image.inc b/meta- > > arago-distro/recipes-core/images/arago-image.inc > > index 98af6c3..977ce8f 100644 > > --- a/meta-arago-distro/recipes-core/images/arago-image.inc > > +++ b/meta-arago-distro/recipes-core/images/arago-image.inc > > @@ -3,7 +3,7 @@ > > LICENSE = "MIT" > > LIC_FILES_CHKSUM = > > "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58" > > > > -IMAGE_FEATURES += "package-management" > > +IMAGE_FEATURES += "package-management splash" 1. We add standard "splash" feature to IMAGE_FEATURES list for all our images. And image class will pull in psplash by default. > > # 4KB per 1 inode should be enough > > EXTRA_IMAGECMD_ext2.gz += "-i 4096" > > diff --git a/meta-arago-distro/recipes-core/images/tisdk-server-rootfs-image.bb > > b/meta-arago-distro/recipes-core/images/tisdk-server-rootfs-image.bb > > index e5ce2b5..908325f 100644 > > --- a/meta-arago-distro/recipes-core/images/tisdk-server-rootfs-image.bb > > +++ b/meta-arago-distro/recipes-core/images/tisdk-server-rootfs-image.bb > > @@ -3,6 +3,8 @@ COMPATIBLE_MACHINE = > > "omap3|omapl138|ti33x|keystone" > > > > require arago-image.inc > > > > +SPLASH = "" > > + > [Sam] I am not sure why is this needed. Appreciate if you clarify. 2. For "server" image, we empty SPLASH variable, which is "psplash" by default. > > IMAGE_INSTALL += "\ > > packagegroup-arago-base \ > > packagegroup-arago-console \ > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup- > > arago-base-tisdk.bb b/meta-arago-distro/recipes- > > core/packagegroups/packagegroup-arago-base-tisdk.bb > > index 704e840..c291a42 100644 > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base- > > tisdk.bb > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago- > > base-tisdk.bb > > @@ -1,6 +1,6 @@ > > DESCRIPTION = "Additional packages beyond console packages shared by TI > > SDKs" > > LICENSE = "MIT" > > -PR = "r14" > > +PR = "r15" > > > > inherit packagegroup > > > > @@ -12,7 +12,6 @@ RDEPENDS_${PN} = "\ > > libpcre \ > > iptables \ > > iperf \ > > - psplash \ > [Sam] I see psplash getting removed here. Does not this be moved to a > different package group? ( I don't see any addition to different package > group). 3. We no longer add psplash explicitly in the packagegroup, since image class takes care of that for us with the steps above. > > arago-gpl-notice \ > > nfs-utils-client \ > > " > > -- > > 2.2.0 > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago