From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id E6A18E00815; Tue, 10 Feb 2015 12:16:10 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high * trust * [198.47.26.153 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id B1184E005A9 for ; Tue, 10 Feb 2015 12:15:57 -0800 (PST) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id t1AKFtnv014909 for ; Tue, 10 Feb 2015 14:15:55 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id t1AKFsEN001920 for ; Tue, 10 Feb 2015 14:15:54 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.224.2; Tue, 10 Feb 2015 14:15:54 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id t1AKFrC9008091; Tue, 10 Feb 2015 14:15:53 -0600 Date: Tue, 10 Feb 2015 15:15:53 -0500 From: Denys Dmytriyenko To: Sam Nelson Message-ID: <20150210201552.GL13231@edge> References: <1422892524-4436-1-git-send-email-sam.nelson@ti.com> MIME-Version: 1.0 In-Reply-To: <1422892524-4436-1-git-send-email-sam.nelson@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: meta-ti@yoctoproject.org Subject: Re: [PATCH 1/2] dfe-lld: Add recipe for Digital Radio Front end low level driver & test code X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 20:16:11 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Two comments, although not very critical: 1. dfe-lld-test defpends on iqn2-lld, which gets added in the second patch. I understand that iqn2-lld depends on dfe-lld, so the proper way to break it into patches and ensure bisectability, is to submit dfe-lld-test recipe separately as a third patch after dfe-lld and iqn2-lld/test. 2. Since you are only building for k2l, do you want to set a more stricter COMPATIBLE_MACHINE as "k2l-evm"? -- Denys On Mon, Feb 02, 2015 at 10:55:23AM -0500, Sam Nelson wrote: > - Provides low level driver for Digital Radio front end > - Supports device k2l > > Signed-off-by: Sam Nelson > --- > recipes-bsp/dfe-lld/dfe-lld-test_git.bb | 18 ++++++++++++++++++ > recipes-bsp/dfe-lld/dfe-lld.inc | 13 +++++++++++++ > recipes-bsp/dfe-lld/dfe-lld_git.bb | 15 +++++++++++++++ > 3 files changed, 46 insertions(+) > create mode 100644 recipes-bsp/dfe-lld/dfe-lld-test_git.bb > create mode 100644 recipes-bsp/dfe-lld/dfe-lld.inc > create mode 100644 recipes-bsp/dfe-lld/dfe-lld_git.bb > > diff --git a/recipes-bsp/dfe-lld/dfe-lld-test_git.bb b/recipes-bsp/dfe-lld/dfe-lld-test_git.bb > new file mode 100644 > index 0000000..acaaf63 > --- /dev/null > +++ b/recipes-bsp/dfe-lld/dfe-lld-test_git.bb > @@ -0,0 +1,18 @@ > +DESCRIPTION = "TI Digital Radio Front End lld test application" > + > +DEPENDS = "common-csl-ip dfe-lld iqn2-lld" > + > +include dfe-lld.inc > + > +EXTRA_OEMAKE = "-f makefile_armv7 PDK_INSTALL_PATH=${STAGING_INCDIR} DFE_SRC_DIR=${S}" > + > +do_compile () { > +# Now build the lld in the updated directory > + oe_runmake clean DEVICE=k2l > + oe_runmake tests DEVICE=k2l > + oe_runmake tests DEVICE=k2l USEDYNAMIC_LIB=yes > +} > + > +do_install () { > + oe_runmake installbin INSTALL_BIN_BASE_DIR=${D}/${bindir} > +} > diff --git a/recipes-bsp/dfe-lld/dfe-lld.inc b/recipes-bsp/dfe-lld/dfe-lld.inc > new file mode 100644 > index 0000000..b1e42e7 > --- /dev/null > +++ b/recipes-bsp/dfe-lld/dfe-lld.inc > @@ -0,0 +1,13 @@ > +LICENSE = "BSD-3-Clause" > + > +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=1f4217b705bf98762a302fd720649dcc" > +BRANCH = "master" > +SRC_URI = "git://git.ti.com/keystone-rtos/dfe-lld.git;destsuffix=git/ti/drv/dfe;protocol=git;branch=${BRANCH}" > +# The following commit correspond to DEV.DFE_LLD.01.00.00.03C > +SRCREV = "ed20e87d3676e3e05ce2b78179b504a05083ad15" > + > +PV = "1.0.0.3" > + > +COMPATIBLE_MACHINE = "keystone" > + > +S = "${WORKDIR}/git/ti/drv/dfe" > diff --git a/recipes-bsp/dfe-lld/dfe-lld_git.bb b/recipes-bsp/dfe-lld/dfe-lld_git.bb > new file mode 100644 > index 0000000..a2477ca > --- /dev/null > +++ b/recipes-bsp/dfe-lld/dfe-lld_git.bb > @@ -0,0 +1,15 @@ > +DESCRIPTION = "Digital Radio Front End low level driver" > + > +DEPENDS = "common-csl-ip" > + > +include dfe-lld.inc > + > +EXTRA_OEMAKE = "-f makefile_armv7 PDK_INSTALL_PATH=${STAGING_INCDIR}" > + > +do_compile () { > + oe_runmake lib DEVICE=k2l > +} > + > +do_install () { > + oe_runmake install INSTALL_INC_BASE_DIR=${D}/${includedir} INSTALL_LIB_BASE_DIR=${D}${libdir} > +} > -- > 1.7.9.5 > > -- > _______________________________________________ > meta-ti mailing list > meta-ti@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-ti