From mboxrd@z Thu Jan  1 00:00:00 1970
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Tue, 10 Feb 2015 22:24:12 +0000
Subject: Re: [PATCH 1/1] staging: android: Remove allocation from declaration line
Message-Id: <20150210222412.GA27072@kroah.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20150210110945.GA17910@sloth>
In-Reply-To: <20150210110945.GA17910@sloth>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Arve =?utf-8?B?SGrvv71ubmV277+9Zw==?= <arve@android.com>, Riley Andrews <riandrews@android.com>, kernel-janitors@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org

On Tue, Feb 10, 2015 at 12:09:45PM +0100, Quentin Lambert wrote:
> This patch removes allocation from declaration line because
> people are known to gloss over declarations.

Then those people should not be reviewing kernel code :)

Seriously, this is unneeded churn, the code is fine as-is.

thanks,

greg k-h

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754785AbbBJWYT (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Feb 2015 17:24:19 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:50882 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754138AbbBJWYS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Feb 2015 17:24:18 -0500
Date: Wed, 11 Feb 2015 06:24:12 +0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Arve =?utf-8?B?SGrvv71ubmV277+9Zw==?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>, kernel-janitors@vger.kernel.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: android: Remove allocation from declaration
 line
Message-ID: <20150210222412.GA27072@kroah.com>
References: <20150210110945.GA17910@sloth>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150210110945.GA17910@sloth>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 10, 2015 at 12:09:45PM +0100, Quentin Lambert wrote:
> This patch removes allocation from declaration line because
> people are known to gloss over declarations.

Then those people should not be reviewing kernel code :)

Seriously, this is unneeded churn, the code is fine as-is.

thanks,

greg k-h