Re: [PATCH 3/4] drm: use drmIoctl everywhere

From: Daniel Vetter <daniel@ffwll.ch>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/4] drm: use drmIoctl everywhere
Date: Wed, 11 Feb 2015 15:34:47 +0100	[thread overview]
Message-ID: <20150211143447.GS24485@phenom.ffwll.local> (raw)
In-Reply-To: <CACvgo52aJENR3GRNvMwCc_YQHgCxq+uV5Vm7bX8=gAzfLmEVaQ@mail.gmail.com>

On Wed, Feb 11, 2015 at 01:13:26PM +0000, Emil Velikov wrote:
> On 11 February 2015 at 11:42, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Well just core drm. All the other callers in there that still use
> > direct calls to ioctl have some custom retry logic already, so should
> > be good already.
> >
> Afaics intel/intel_bufmgr_gem.c has one instance, plus most of the tests.

That one is in set_tiling and because of a very peculiar retry semantics
of that specific ioctl. Don't ask ;-)
> 
> > freedreno/kgsl ahas all the other bare ioctl calls, dunnot what to do
> > about that.
> >
> s/ahas/has/ if you choose to keep this note.

Already reworded since kgsl is the blob library and so not a drm thing.

Thanks for your review.
-Daniel
> 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
> 
> -Emil

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx