Re: [Qemu-devel] [PATCH v2 2/3] Add migrate_incoming

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Juan Quintela (quintela@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Add migrate_incoming/migrate-incoming to start an incoming
> > migration.
> >
> > Once a qemu has been started with
> >     -incoming pause
> >
> > the migration can be started by issuing:
> >     migrate_incoming uri
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> 
> > +        .name       = "migrate_incoming",
> > +        .args_type  = "uri:s",
> > +        .params     = "uri",
> > +        .help       = "Unpause an incoming migration from an -incoming pause",
> > +        .mhandler.cmd = hmp_migrate_incoming,
> > +    },
> 
> As you know, I am a funny man, so .....
> 
> (qemu) migrate_incoming paused
> 
> funny, right?

(qemu) migrate_incoming paused
unknown migration protocol: paused
(qemu) migrate_incoming pause
Pausing an already paused incoming migration

Didn't want to let you get away with that :-)

> Not that --incomining in general is well prepared for abuse O:-)

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK