From: Greg KH <gregkh@linuxfoundation.org>
To: dsterba@suse.cz, Anand Jain <anand.jain@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
clm@fb.com
Subject: Re: [PATCH 1/1 V2] export symbol kobject_move()
Date: Thu, 12 Feb 2015 18:47:15 +0800 [thread overview]
Message-ID: <20150212104715.GA3503@kroah.com> (raw)
In-Reply-To: <20150212095314.GP28877@suse.cz>
On Thu, Feb 12, 2015 at 10:53:14AM +0100, David Sterba wrote:
> Adding Greg to CC.
>
> On Thu, Feb 12, 2015 at 07:03:37AM +0800, Anand Jain wrote:
> > drivers/cpufreq/cpufreq.c is already using this function. And now btrfs
> > needs it as well. export symbol kobject_move().
> >
> > Signed-off-by: Anand Jain <anand.jain@oracle.com>
> > ---
> > v1->v2: Didn't notice there wasn't my signed-off, now added. Thanks Dave.
> >
> > lib/kobject.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/kobject.c b/lib/kobject.c
> > index 58751bb..e055c06 100644
> > --- a/lib/kobject.c
> > +++ b/lib/kobject.c
> > @@ -548,6 +548,7 @@ out:
> > kfree(devpath);
> > return error;
> > }
> > +EXPORT_SYMBOL_GPL(kobject_move);
>
> Looks ok to me. There's another user of this function in
> drivers/cpufreq/cpufreq.c, but apparenly not a module so the export was
> not needed.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2015-02-12 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 23:48 [PATCH 1/1] export symbol kobject_move() Anand Jain
2015-02-11 23:03 ` [PATCH 1/1 V2] " Anand Jain
2015-02-12 9:53 ` David Sterba
2015-02-12 10:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212104715.GA3503@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.