Re: [PATCHv2] input: rotary encoder: Add wake up support

[Sylvain Rochet <sylvain.rochet@finsecur.com>]

Hello Johan,

On Sun, Feb 08, 2015 at 12:07:16PM +0800, Johan Hovold wrote:
> On Thu, Jan 29, 2015 at 12:10:18PM +0100, Sylvain Rochet wrote:
> > This patch add wake up support for rotary encoders.
> > 
> > Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> 
> > @@ -306,6 +311,8 @@ static int rotary_encoder_remove(struct platform_device *pdev)
> >  	struct rotary_encoder *encoder = platform_get_drvdata(pdev);
> >  	const struct rotary_encoder_platform_data *pdata = encoder->pdata;
> >  
> > +	device_init_wakeup(&pdev->dev, 0);
> > +
> 
> Perhaps you should use false rather than 0 here for consistency. 

I agree, done.


> Looks good otherwise, so feel free to add my
> 
> Reviewed-by: Johan Hovold <johan@kernel.org>

Thank you Johan :)


> If you resend, you could split the device-tree binding documentation in
> a separate patch that you CC the devicetree list in order to get an ack
> for the property name.

I agree, done.


Sylvain