Re: xt_recent fails with kernel 3.19.0

[Florian Westphal <fw@strlen.de>]

Chris Vine <chris@cvine.freeserve.co.uk> wrote:
> On Thu, 12 Feb 2015 18:09:31 +0100
> Florian Westphal <fw@strlen.de> wrote:
> [snip]
> > > This patch seems to be doing
> > > something different, and I note that nstamps_max_mask is
> > > unconditionally set later in recent_mt_check() anyway.
> > 
> > No, its only set if recent_table_lookup returns NULL.
> > We return soon after we bump the refcnt when we take this branch.
> 
> You probably are working on a more up-to-date branch.  Your patch
> assigning to nstamps_max_mask is only executed if recent_table_lookup()
> does not return NULL.  In the 3.19.0 kernel, the assignment to
> nstamps_max_mask in line 404 also only occurs if recent_table_lookup()
> does not return NULL.

Thats what I meant -- line 404 is ONLY executed if the table doesn't
exist, so we need to assign it in case we have a table and we want
to increase the upper limit of the _existing_ table.

Unless someone spots an issue with this approach i'll submit this
formally tomorrow.