From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "ext4 development" <linux-ext4@vger.kernel.org>,
Cónräd <conradsand.arma@gmail.com>
Subject: Re: [PATCH 2/2, RFC] ext4: ignore journal checksum on remount; don't fail
Date: Thu, 12 Feb 2015 23:09:09 -0500 [thread overview]
Message-ID: <20150213040909.GE2268@thunk.org> (raw)
In-Reply-To: <54DA366E.8060109@redhat.com>
On Tue, Feb 10, 2015 at 10:48:46AM -0600, Eric Sandeen wrote:
> As of v3.18, ext4 started rejecting a remount which changes the
> journal_checksum option.
>
> Prior to that, it was simply ignored; the problem here is that
> if someone has this in their fstab for the root fs, now the box
> fails to boot properly, because remount of root with the new options
> will fail, and the box proceeds with a readonly root.
>
> I think it is a little nicer behavior to accept the option, but
> warn that it's being ignored, rather than failing the mount,
> but that might be a subjective matter...
>
> Reported-by: Cónräd <conradsand.arma@gmail.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied, thanks.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-02-13 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 16:41 [PATCH 1/2] ext4: remove duplicate remount check for JOURNAL_CHECKSUM change Eric Sandeen
2015-02-10 16:48 ` [PATCH 2/2, RFC] ext4: ignore journal checksum on remount; don't fail Eric Sandeen
2015-02-13 4:09 ` Theodore Ts'o [this message]
2015-02-13 4:05 ` [PATCH 1/2] ext4: remove duplicate remount check for JOURNAL_CHECKSUM change Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213040909.GE2268@thunk.org \
--to=tytso@mit.edu \
--cc=conradsand.arma@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.