diff for duplicates of <20150213112125.GA25078@linuxteamdev.amer.dell.com> diff --git a/a/1.txt b/N1/1.txt index e3df7b0..a06b616 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,7 +4,7 @@ Hi All, This patch soves the indentation warning in amba-clcd.c file. Please review the same. -From a5f58880b2a6fd7cc532c4fb2bf6543cf1945195 Mon Sep 17 00:00:00 2001 +>From a5f58880b2a6fd7cc532c4fb2bf6543cf1945195 Mon Sep 17 00:00:00 2001 From: Parmeshwr Prasad <parmeshwr_prasad@dell.com> Date: Thu, 12 Feb 2015 07:30:04 -0500 Subject: [PATCH 1/2] Trivial patch: Removed indentation warnings @@ -56,7 +56,8 @@ fb_var_screeninfo *var) var->green.offset = var->red.offset + var->red.length; - var->blue.offset = var->green.offset + var->green.length; -+ var->blue.offset + var->green.offset + var->green.length; ++ var->blue.offset = ++ var->green.offset + var->green.length; } } @@ -96,7 +97,7 @@ unsigned int green, + convert_bitfield(green, &fb->fb.var.green) | + convert_bitfield(red, &fb->fb.var.red); - if (fb->fb.fix.visual = FB_VISUAL_PSEUDOCOLOR && regno < 256) { + if (fb->fb.fix.visual == FB_VISUAL_PSEUDOCOLOR && regno < 256) { int hw_reg = CLCD_PALETTE + ((regno * 2) & ~3); u32 val, mask, newval; @@ -247,7 +248,7 @@ unsigned int green, + fb->board->name, fb->panel->mode.name); ret = register_framebuffer(&fb->fb); - if (ret = 0) + if (ret == 0) @@ -540,19 +539,19 @@ static int clcdfb_register(struct clcd_fb *fb) printk(KERN_ERR "CLCD: cannot register framebuffer (%d)\n", ret); @@ -332,9 +333,9 @@ u32 r0, u32 g0, u32 b0) if (of_property_read_u32_array(endpoint, - "arm,pl11x,tft-r0g0b0-pads", -- tft_r0b0g0, ARRAY_SIZE(tft_r0b0g0)) = 0) +- tft_r0b0g0, ARRAY_SIZE(tft_r0b0g0)) == 0) + "arm,pl11x,tft-r0g0b0-pads", -+ tft_r0b0g0, ARRAY_SIZE(tft_r0b0g0)) = 0) ++ tft_r0b0g0, ARRAY_SIZE(tft_r0b0g0)) == 0) return clcdfb_of_init_tft_panel(fb, tft_r0b0g0[0], - tft_r0b0g0[1], tft_r0b0g0[2]); + tft_r0b0g0[1], tft_r0b0g0[2]); @@ -439,7 +440,7 @@ struct amba_id *id) - ret = clcdfb_register(fb); + ret = clcdfb_register(fb); - if (ret = 0) { + if (ret == 0) { amba_set_drvdata(dev, fb); goto out; } diff --git a/a/content_digest b/N1/content_digest index b0cae0c..2007045 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Parmeshwr Prasad <parmeshwr_prasad@dell.com>\0" "Subject\0[PATCH 1/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver\0" - "Date\0Fri, 13 Feb 2015 11:21:33 +0000\0" + "Date\0Fri, 13 Feb 2015 06:21:33 -0500\0" "To\0linux@arm.linux.org.uk\0" "Cc\0plagnioj@jcrosoft.com" tomi.valkeinen@ti.com @@ -15,7 +15,7 @@ "This patch soves the indentation warning in amba-clcd.c file.\n" "Please review the same.\n" "\n" - "From a5f58880b2a6fd7cc532c4fb2bf6543cf1945195 Mon Sep 17 00:00:00 2001\n" + ">From a5f58880b2a6fd7cc532c4fb2bf6543cf1945195 Mon Sep 17 00:00:00 2001\n" "From: Parmeshwr Prasad <parmeshwr_prasad@dell.com>\n" "Date: Thu, 12 Feb 2015 07:30:04 -0500\n" "Subject: [PATCH 1/2] Trivial patch: Removed indentation warnings\n" @@ -67,7 +67,8 @@ " var->green.offset = var->red.offset + var->red.length;\n" "- var->blue.offset = var->green.offset +\n" "var->green.length;\n" - "+ var->blue.offset + var->green.offset + var->green.length;\n" + "+ var->blue.offset =\n" + "+ var->green.offset + var->green.length;\n" " }\n" " }\n" "\n" @@ -107,7 +108,7 @@ "+ convert_bitfield(green, &fb->fb.var.green) |\n" "+ convert_bitfield(red, &fb->fb.var.red);\n" "\n" - " if (fb->fb.fix.visual = FB_VISUAL_PSEUDOCOLOR && regno < 256) {\n" + " if (fb->fb.fix.visual == FB_VISUAL_PSEUDOCOLOR && regno < 256) {\n" " int hw_reg = CLCD_PALETTE + ((regno * 2) & ~3);\n" " u32 val, mask, newval;\n" "\n" @@ -258,7 +259,7 @@ "+ fb->board->name, fb->panel->mode.name);\n" "\n" " ret = register_framebuffer(&fb->fb);\n" - " if (ret = 0)\n" + " if (ret == 0)\n" "@@ -540,19 +539,19 @@ static int clcdfb_register(struct clcd_fb *fb)\n" " printk(KERN_ERR \"CLCD: cannot register framebuffer (%d)\\n\", ret);\n" "\n" @@ -343,9 +344,9 @@ "\n" " if (of_property_read_u32_array(endpoint,\n" "- \"arm,pl11x,tft-r0g0b0-pads\",\n" - "- tft_r0b0g0, ARRAY_SIZE(tft_r0b0g0)) = 0)\n" + "- tft_r0b0g0, ARRAY_SIZE(tft_r0b0g0)) == 0)\n" "+ \"arm,pl11x,tft-r0g0b0-pads\",\n" - "+ tft_r0b0g0, ARRAY_SIZE(tft_r0b0g0)) = 0)\n" + "+ tft_r0b0g0, ARRAY_SIZE(tft_r0b0g0)) == 0)\n" " return clcdfb_of_init_tft_panel(fb, tft_r0b0g0[0],\n" "- tft_r0b0g0[1], tft_r0b0g0[2]);\n" "+ tft_r0b0g0[1], tft_r0b0g0[2]);\n" @@ -450,7 +451,7 @@ "\n" "- ret = clcdfb_register(fb);\n" "+ ret = clcdfb_register(fb);\n" - " if (ret = 0) {\n" + " if (ret == 0) {\n" " amba_set_drvdata(dev, fb);\n" " goto out;\n" " }\n" @@ -505,4 +506,4 @@ "\n" -Parmeshwr -0d5752feb6cd22113f93e98de4e53dd35b903a7b6327909523eeb9835b435606 +6fa0dc3e6d6685ff6b1bb27d60ceaf7e0532e44577464945d28f3dd39cd1ce95
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.