diff for duplicates of <20150213132805.GA1296@linuxteamdev.amer.dell.com> diff --git a/a/1.txt b/N1/1.txt index 1339495..0bfe6ce 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ I have used schedule_timeout() function for same amount of delay. Please review the same. Patch 1/2 I will fix comments and re-submitt. -From 06b275e44a3951ec0a57af59aea2a4c82595e456 Mon Sep 17 00:00:00 2001 +>From 06b275e44a3951ec0a57af59aea2a4c82595e456 Mon Sep 17 00:00:00 2001 From: Parmeshwr Prasad <parmeshwr_prasad@dell.com> Date: Fri, 13 Feb 2015 06:10:34 -0500 Subject: [PATCH 2/2] Patch to replace in_atomic with proper function from @@ -107,7 +107,7 @@ index 0ddc1f0..7e630f5c 100644 goto clk_unprep; } @@ -536,7 +534,7 @@ static int clcdfb_register(struct clcd_fb *fb) - if (ret = 0) + if (ret == 0) goto out; - printk(KERN_ERR "CLCD: cannot register framebuffer (%d)\n", ret); @@ -166,7 +166,8 @@ On Fri, Feb 13, 2015 at 05:59:56AM -0600, Joe Perches wrote: > > Perhaps this could be better as: > -> fb->fb.fix.smem_start > of_translate_address(memory, +> fb->fb.fix.smem_start = +> of_translate_address(memory, > of_get_address(memory, 0, &size, NULL)); > > But sometimes using multiple statements instead of diff --git a/a/content_digest b/N1/content_digest index 24e5028..0b15826 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\01423828796.2795.7.camel@perches.com\0" "From\0Parmeshwr Prasad <parmeshwr_prasad@dell.com>\0" "Subject\0Re: [PATCH 2/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver\0" - "Date\0Fri, 13 Feb 2015 13:28:10 +0000\0" + "Date\0Fri, 13 Feb 2015 08:28:10 -0500\0" "To\0Joe Perches <joe@perches.com>\0" "Cc\0Russell King - ARM Linux <linux@arm.linux.org.uk>" plagnioj@jcrosoft.com <plagnioj@jcrosoft.com> @@ -21,7 +21,7 @@ "\n" "Please review the same.\n" "Patch 1/2 I will fix comments and re-submitt.\n" - "From 06b275e44a3951ec0a57af59aea2a4c82595e456 Mon Sep 17 00:00:00 2001\n" + ">From 06b275e44a3951ec0a57af59aea2a4c82595e456 Mon Sep 17 00:00:00 2001\n" "From: Parmeshwr Prasad <parmeshwr_prasad@dell.com>\n" "Date: Fri, 13 Feb 2015 06:10:34 -0500\n" "Subject: [PATCH 2/2] Patch to replace in_atomic with proper function from\n" @@ -122,7 +122,7 @@ " goto clk_unprep;\n" " }\n" "@@ -536,7 +534,7 @@ static int clcdfb_register(struct clcd_fb *fb)\n" - " if (ret = 0)\n" + " if (ret == 0)\n" " goto out;\n" "\n" "- printk(KERN_ERR \"CLCD: cannot register framebuffer (%d)\\n\", ret);\n" @@ -181,7 +181,8 @@ "> \n" "> Perhaps this could be better as:\n" "> \n" - "> \tfb->fb.fix.smem_start > \t\t of_translate_address(memory,\n" + "> \tfb->fb.fix.smem_start =\n" + "> \t\t of_translate_address(memory,\n" "> \t\t\t\t of_get_address(memory, 0, &size, NULL));\n" "> \n" "> But sometimes using multiple statements instead of\n" @@ -198,4 +199,4 @@ "> \n" > -ba58ada18f0765c297e239826a5335e8586ee5238b30beaa1b6b8ae70fe3cd2f +815f426a0158c9231ddf87a7df3338a0f4b9626529d8c9111d2f4134f30b525b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.