From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 3/7] dm-crypt: avoid deadlock in mempools Date: Fri, 13 Feb 2015 20:14:46 -0500 Message-ID: <20150214011445.GA14223@redhat.com> References: <20150213211614.GA7180@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mikulas Patocka Cc: Ondrej Kozina , dm-devel@redhat.com, "Alasdair G. Kergon" , Milan Broz List-Id: dm-devel.ids On Fri, Feb 13 2015 at 5:09P -0500, Mikulas Patocka wrote: > > > On Fri, 13 Feb 2015, Mike Snitzer wrote: > > > * In order to not degrade performance with excessive locking, we try > > - * non-blocking allocations without a mutex first and if it fails, we fallback > > + * non-blocking allocation without a mutex first and if it fails, we fallback > > * to a blocking allocation with a mutex. > > */ > > static struct bio *crypt_alloc_buffer(struct dm_crypt_io *io, unsigned size) > > There are multiple allocations, so I would leave plural there. Fixed, and tweaked the headers (already did that last time around so nothing new, you just didn't pick up my headers for your v2). I pushed your patchset to linux-next (for 3.21), see: https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/log/?h=for-next Ondrej and Milan, please let us know if you hit any problems with this patchset and/or branch.