All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] qt5base: disable gold linker
Date: Sat, 14 Feb 2015 08:58:13 +0100	[thread overview]
Message-ID: <20150214085813.341d2811@free-electrons.com> (raw)
In-Reply-To: <87oaozzbsj.fsf@dell.be.48ers.dk>

Dear Peter Korsgaard,

On Thu, 12 Feb 2015 11:03:56 +0100, Peter Korsgaard wrote:

> The problem is that the configure script is confused. While this is
> related to linking, -fuse-ld=gold is an argument to the compiler driver
> to tell it what linker to execute, NOT an option to tell the linker to
> behave differently. So it shouldn't get prefixed with -Wl when passed
> though the compiler driver.
> 
> Qt does the right thing when it uses it, but the configure script does:
> 
>     if linkerSupportsFlag $TEST_COMPILER -fuse-ld=gold; then
>        CFG_USE_GOLD_LINKER=yes
> 
> This should be compilerSupportsFlag instead.
> 
> I'll create a patch and apply / send upstream.

Thanks. In the mean time, I've marked the original patch from Peter
Seiderer as Rejected in patchwork.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-02-14  7:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  6:47 [Buildroot] [PATCH v1] qt5base: disable gold linker Peter Seiderer
2015-02-11 14:32 ` Thomas Petazzoni
2015-02-11 15:53   ` Sagaert Johan
2015-02-11 16:06   ` Peter Seiderer
2015-02-11 19:00   ` Sagaert Johan
2015-02-12 10:03   ` Peter Korsgaard
2015-02-14  7:58     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150214085813.341d2811@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.