From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YMfZc-0004jy-J6 for mharc-grub-devel@gnu.org; Sat, 14 Feb 2015 11:28:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56846) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMfZV-0004eI-Le for grub-devel@gnu.org; Sat, 14 Feb 2015 11:28:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMfZQ-0001Lr-Mu for grub-devel@gnu.org; Sat, 14 Feb 2015 11:27:57 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:41886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMfZQ-0001Kv-Fv for grub-devel@gnu.org; Sat, 14 Feb 2015 11:27:52 -0500 Received: by labpv20 with SMTP id pv20so21458679lab.8 for ; Sat, 14 Feb 2015 08:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=CFPSDqv5AXvYZDoTdvN+vcuYhKRgBaTnpjCb9cimB3c=; b=qKw7Knh1ab5iZjyfUmuwx/+B9++4/VKnE1IVShag4fBs96T4oJ0VteL5ChIDKuTtfw FcGjNLk3QKswN9sCabK5/xVlDFiIHPoiQi+RJIlLX+98ZPlyNe+EtSGKHU+hsumSdzxz vtNos9p2dHS5jbYE86U4NLOhK+aGtgiRI6oUDelgP1rykzttd1n8YGDvxa5uZXzTNu39 kjykn+YKyLfeckxFl2p029KpT6tf4HvLDDObkceT95JNGCMyfO3fUiYjCVI0w7s0pGX8 uO4YARvkxnUzzp4tfRWsG3EVTDVBNiA7vJ40zFGxCC8YrtHU7qTT/VwZPh3oA1DTpFvw JaLA== X-Received: by 10.112.214.204 with SMTP id oc12mr1257471lbc.10.1423931271646; Sat, 14 Feb 2015 08:27:51 -0800 (PST) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id j9sm1981263lbp.7.2015.02.14.08.27.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Feb 2015 08:27:50 -0800 (PST) Date: Sat, 14 Feb 2015 19:27:49 +0300 From: Andrei Borzenkov To: Daniel Kiper Subject: Re: [PATCH 1/5] multiboot2: Fix information request tag size calculation Message-ID: <20150214192749.34bcb19f@opensuse.site> In-Reply-To: <1422640768-28181-2-git-send-email-daniel.kiper@oracle.com> References: <1422640768-28181-1-git-send-email-daniel.kiper@oracle.com> <1422640768-28181-2-git-send-email-daniel.kiper@oracle.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.215.44 Cc: jgross@suse.com, grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, phcoder@gmail.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2015 16:28:02 -0000 =D0=92 Fri, 30 Jan 2015 18:59:24 +0100 Daniel Kiper =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Signed-off-by: Daniel Kiper > --- > grub-core/loader/multiboot_mbi2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/grub-core/loader/multiboot_mbi2.c b/grub-core/loader/multibo= ot_mbi2.c > index 6f74aee..d7c19bc 100644 > --- a/grub-core/loader/multiboot_mbi2.c > +++ b/grub-core/loader/multiboot_mbi2.c > @@ -150,7 +150,7 @@ grub_multiboot_load (grub_file_t file, const char *fi= lename) > =3D (struct multiboot_header_tag_information_request *) tag; > if (request_tag->flags & MULTIBOOT_HEADER_TAG_OPTIONAL) > break; > - for (i =3D 0; i < (request_tag->size - sizeof (request_tag)) > + for (i =3D 0; i < (request_tag->size - sizeof (*request_tag)) > / sizeof (request_tag->requests[0]); i++) > switch (request_tag->requests[i]) > { Applied. Thanks!