From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Lunar <lunar@torproject.org>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse
Date: Sat, 14 Feb 2015 20:48:14 +0300 [thread overview]
Message-ID: <20150214204814.26817372@opensuse.site> (raw)
In-Reply-To: <20150214082219.GC4754@loar>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
В Sat, 14 Feb 2015 09:22:19 +0100
Lunar <lunar@torproject.org> пишет:
> Andrei Borzenkov:
> > В Fri, 13 Feb 2015 22:09:04 +0100
> > Lunar <lunar@torproject.org> пишет:
> >
> > > Andrei Borzenkov:
> > > > [… review and comments …]
> > >
> > > Ok, here's another try.
> > >
> >
> > It looks OK but as someone reported that your patches seem to cause
> > problems elsewhere let's wait for confirmation.
> >
> > @gluglug - could you test both update versions? Thank you.
>
> fchmmr said that there was an issue with Trisquel 7.0 GNOME. But if
> there's one, it doesn't seem to be related to the patches.
>
Well, one of your patches had double free, it may lead to unexpected
results. It would still be helpful to confirm that problem went away.
BTW if you could write test for syslinux parser it would be great!
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2015-02-14 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150213-163409.sv98365.64186@savannah.gnu.org>
[not found] ` <20150213-190108.sv89796.21318@savannah.gnu.org>
2015-02-13 20:20 ` [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse Lunar
2015-02-13 20:40 ` Andrei Borzenkov
2015-02-13 21:09 ` Lunar
2015-02-14 6:15 ` Andrei Borzenkov
2015-02-14 8:22 ` Lunar
2015-02-14 17:48 ` Andrei Borzenkov [this message]
2015-03-17 17:41 ` The Gluglug
2015-02-14 3:26 The Gluglug
-- strict thread matches above, loose matches on Subject: below --
2015-03-17 17:40 The Gluglug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150214204814.26817372@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=lunar@torproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.