From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YMgpT-0002O2-8z for mharc-grub-devel@gnu.org; Sat, 14 Feb 2015 12:48:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMgpM-0002AL-JL for grub-devel@gnu.org; Sat, 14 Feb 2015 12:48:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMgpG-0006Lg-2R for grub-devel@gnu.org; Sat, 14 Feb 2015 12:48:24 -0500 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]:47424) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMgpF-0006LP-KS for grub-devel@gnu.org; Sat, 14 Feb 2015 12:48:17 -0500 Received: by mail-lb0-f180.google.com with SMTP id z12so20705637lbi.11 for ; Sat, 14 Feb 2015 09:48:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=Q1h17yqJPhCcEaTxV13UtM+iEQlSBsDCyWvwiJmJwU4=; b=DYzgJf9H/7op1wEWycky7/Fi/O8XW4v9p9AxMVgmY4OKLqHrUeubFHpMibRs3r+Ek5 9jGS7JYLg/wyxGLTnh7O7mz7QdZXE9ZTTWbXo5DTN6qodpmHHYTEnjwxQjR6owoeSr5e uUXhFv2MG89V18C/P3O6ESOTQM1r3baHL1XsEDsTNAuK1JXyHf77kCBFpwTk98vvc1F8 N/ZEdIXeq6LAaolI2zMHy8jJ5vAkOXWdVv06D0Jp9huhzGF9h0Am3w1NlkIz4wLKCZSy ZZeOQXnz6xQxDZEIcgYUb0XyhuJCHiZF2q79qfuDGMs9owi3DW82iUuDQ4OVCLoHqwNQ C6ew== X-Received: by 10.152.87.50 with SMTP id u18mr13714078laz.82.1423936096754; Sat, 14 Feb 2015 09:48:16 -0800 (PST) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id lf3sm2013442lbc.2.2015.02.14.09.48.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Feb 2015 09:48:15 -0800 (PST) Date: Sat, 14 Feb 2015 20:48:14 +0300 From: Andrei Borzenkov To: Lunar Subject: Re: [bug #44238] Add support for menu.c32 and vesamenu.c32 in lib/syslinux_parse Message-ID: <20150214204814.26817372@opensuse.site> In-Reply-To: <20150214082219.GC4754@loar> References: <20150213-163409.sv98365.64186@savannah.gnu.org> <20150213-190108.sv89796.21318@savannah.gnu.org> <20150213202023.GF688@loar> <20150213234024.48b03da1@opensuse.site> <20150213210904.GH688@loar> <20150214091509.7a8cc5d0@opensuse.site> <20150214082219.GC4754@loar> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.25; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/fFpDEVykRIrLr=mBcQmcZY8"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::234 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2015 17:48:29 -0000 --Sig_/fFpDEVykRIrLr=mBcQmcZY8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sat, 14 Feb 2015 09:22:19 +0100 Lunar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Andrei Borzenkov: > > =D0=92 Fri, 13 Feb 2015 22:09:04 +0100 > > Lunar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > >=20 > > > Andrei Borzenkov: > > > > [=E2=80=A6 review and comments =E2=80=A6] > > >=20 > > > Ok, here's another try. > > >=20 > >=20 > > It looks OK but as someone reported that your patches seem to cause > > problems elsewhere let's wait for confirmation. > >=20 > > @gluglug - could you test both update versions? Thank you. >=20 > fchmmr said that there was an issue with Trisquel 7.0 GNOME. But if > there's one, it doesn't seem to be related to the patches. >=20 Well, one of your patches had double free, it may lead to unexpected results. It would still be helpful to confirm that problem went away. BTW if you could write test for syslinux parser it would be great! --Sig_/fFpDEVykRIrLr=mBcQmcZY8 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTfil4ACgkQR6LMutpd94wSdwCfSlTP5OJPH3H7ccOXmr/eKKuL jv4AoIlgj64EYZtKCw7HiOpG9DB69GQw =ea7j -----END PGP SIGNATURE----- --Sig_/fFpDEVykRIrLr=mBcQmcZY8--