[Buildroot] [PATCH 1/4] br-reproduce-build: accept BASE_GIT and OUTPUT_DIR from the env

[Yann E. MORIN <yann.morin.1998@free.fr>]

Thomas, All,

On 2015-02-14 22:08 +0100, Thomas Petazzoni spake thusly:
> Dear Yann E. MORIN,
> 
> On Sat, 14 Feb 2015 11:52:03 +0100, Yann E. MORIN wrote:
> > Currently, when we want to set those variables, one has to edit the
> > script, so would get a conflict on the next git-pull.
> > 
> > Instead, allow the user to specify those variables in the environment.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> >  utils/br-reproduce-build | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied, thanks. Though maybe the chosen environment variable names are
> a bit too generic to be globally exported in the user's .bashrc file,
> for example.

Indeed not. However, I use it like:

    BASE_GIT=~/cache/upstream/buildroot OUTPUT_DIR=$(pwd) \
    ./buildroot-test/utils/br-reproduce-build sha1

Which IMHO is good enough. :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'