All of lore.kernel.org
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i.MX6: WEIM: put node reference on early loop exit
Date: Mon, 16 Feb 2015 06:47:02 +0100	[thread overview]
Message-ID: <20150216054702.GF12209@pengutronix.de> (raw)
In-Reply-To: <1423848784-6988-1-git-send-email-alison_chaiken@mentor.com>

On Fri, Feb 13, 2015 at 09:33:04AM -0800, alison at she-devel.com wrote:
> From: Alison Chaiken <alison_chaiken@mentor.com>
> 
> Signed-off-by: Alison Chaiken <alison_chaiken@mentor.com>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Looking at the code I get the question why the current code bails out on
error. Wouldn't it be better to just skip erroneous child devices and
issue a warning?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2015-02-16  5:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 17:33 [PATCH] i.MX6: WEIM: put node reference on early loop exit alison at she-devel.com
2015-02-16  5:47 ` Sascha Hauer [this message]
2015-02-17 16:28   ` Chaiken, Alison
2015-02-17 17:51     ` Joshua Clayton
2015-02-18  8:37       ` [PATCH] i.MX6: WEIM: improve error handling upon child probe-failure alison at she-devel.com
2015-02-18 16:30         ` Joshua Clayton
2015-02-19  7:19       ` [PATCH v3 0/1] " alison at she-devel.com
2015-02-19  7:24       ` [PATCH v3 1/1] " alison at she-devel.com
2015-02-23  7:17         ` Sascha Hauer
2015-03-02 13:51         ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150216054702.GF12209@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.