From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932267AbbBPJx6 (ORCPT ); Mon, 16 Feb 2015 04:53:58 -0500 Received: from casper.infradead.org ([85.118.1.10]:54707 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090AbbBPJx5 (ORCPT ); Mon, 16 Feb 2015 04:53:57 -0500 Date: Mon, 16 Feb 2015 10:53:50 +0100 From: Peter Zijlstra To: Linus Walleij Cc: linux-kernel@vger.kernel.org, Grant Likely , Benjamin Herrenschmidt , Thomas Gleixner Subject: Re: [PATCH 2/2 v2] kernel: irq: rename irq_set_default_host to irq_domain_set_default() Message-ID: <20150216095350.GH7119@twins.programming.kicks-ass.net> References: <1423785737-29878-1-git-send-email-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423785737-29878-1-git-send-email-linus.walleij@linaro.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 13, 2015 at 08:02:17AM +0800, Linus Walleij wrote: > This function does not conform to the irq_domain* namespace and > makes it a disturbing artifact dating back to a time when irq > domains were referred to as "hosts". Rename it. > > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Might as well commit changes I have in the working tree so the > thing compiles like it did in my tests, d'oh. > --- > arch/arc/kernel/irq.c | 2 +- > arch/arm/mach-pxa/irq.c | 2 +- > arch/c6x/kernel/irq.c | 2 +- > arch/microblaze/kernel/intc.c | 2 +- > arch/mips/cavium-octeon/octeon-irq.c | 4 ++-- > arch/nios2/kernel/irq.c | 2 +- > arch/powerpc/platforms/52xx/mpc52xx_pic.c | 2 +- > arch/powerpc/platforms/amigaone/setup.c | 2 +- > arch/powerpc/platforms/cell/beat_interrupt.c | 2 +- > arch/powerpc/platforms/cell/interrupt.c | 2 +- > arch/powerpc/platforms/chrp/setup.c | 2 +- > arch/powerpc/platforms/embedded6xx/flipper-pic.c | 2 +- > arch/powerpc/platforms/powermac/pic.c | 2 +- > arch/powerpc/platforms/ps3/interrupt.c | 2 +- > arch/powerpc/sysdev/ehv_pic.c | 2 +- > arch/powerpc/sysdev/ipic.c | 2 +- > arch/powerpc/sysdev/mpic.c | 2 +- > arch/powerpc/sysdev/uic.c | 2 +- > arch/powerpc/sysdev/xics/xics-common.c | 2 +- > arch/powerpc/sysdev/xilinx_intc.c | 2 +- > arch/x86/kernel/apic/io_apic.c | 2 +- > drivers/irqchip/irq-armada-370-xp.c | 2 +- > drivers/irqchip/irq-clps711x.c | 2 +- > drivers/irqchip/irq-mmp.c | 8 ++++---- > drivers/irqchip/irq-xtensa-mx.c | 4 ++-- > drivers/irqchip/irq-xtensa-pic.c | 4 ++-- > include/linux/irqdomain.h | 2 +- > kernel/irq/irqdomain.c | 14 +++++++------- > 28 files changed, 40 insertions(+), 40 deletions(-) Might it make sense to preserve both functions for one release to avoid flag day changes and broken compiles? Mark one __deprecated and point a comment to the new one, then make sure nobody is still using it by the next release and remove the old interface?