From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 6/7] dm-crypt: make it possible to disable offload to thread Date: Mon, 16 Feb 2015 09:08:48 -0500 Message-ID: <20150216140848.GA20303@redhat.com> References: Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mikulas Patocka Cc: Ondrej Kozina , dm-devel@redhat.com, "Alasdair G. Kergon" , Milan Broz List-Id: dm-devel.ids On Fri, Feb 13 2015 at 8:27am -0500, Mikulas Patocka wrote: > There are some situation where offloading bios to a thread degrades > performance twice, so we make an option to disable this feature. The > feature can be disabled by passing performance_no_offload as an optional > table argument performance_no_offload. > > We increase target version to 14 so that userspace can be aware of this > feature. > > The default is to offload bios because for CFQ it is benefical to do so. > > Signed-off-by: Mikulas Patocka I changed the option to 'submit_writes_from_encrypt_threads', see: https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-for-3.20&id=70a296ba4bfff0355fd57d29ad607ad79590635d I'm open to other names for this option but felt your original 'performance_no_offload' was too opaque to users.