From: Lauri Kasanen <cand@gmx.com>
To: jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, benjamin.tissoires@gmail.com
Cc: ao2@ao2.it, AndrewD207@aol.com
Subject: [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers
Date: Mon, 16 Feb 2015 15:06:59 +0200 [thread overview]
Message-ID: <20150216150659.db522f3d.cand@gmx.com> (raw)
Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send
any events. Now everything works including the leds.
Based on work by Andrew Haines and Antonio Ospite.
cc: Antonio Ospite <ao2@ao2.it>
cc: Andrew Haines <AndrewD207@aol.com>
Signed-off-by: Lauri Kasanen <cand@gmx.com>
---
drivers/hid/hid-sony.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
Antonio: size 8 works.
v4:
- use size 8
v3:
- reuse the dummy heap buffer
- skip later checks if the earlier ones fail
v2:
- edited error messages
- use output_report
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 31e9d25..f3d44e5 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -1139,9 +1139,29 @@ static int sixaxis_set_operational_usb(struct hid_device *hdev)
ret = hid_hw_raw_request(hdev, 0xf2, buf, 17, HID_FEATURE_REPORT,
HID_REQ_GET_REPORT);
+ if (ret < 0) {
+ hid_err(hdev, "can't set operational mode: step 1\n");
+ goto out;
+ }
+
+ /*
+ * Some compatible controllers like the Speedlink Strike FX and
+ * Gasia need another query plus an USB interrupt to get operational.
+ */
+ ret = hid_hw_raw_request(hdev, 0xf5, buf, 8, HID_FEATURE_REPORT,
+ HID_REQ_GET_REPORT);
+
+ if (ret < 0) {
+ hid_err(hdev, "can't set operational mode: step 2\n");
+ goto out;
+ }
+
+ ret = hid_hw_output_report(hdev, buf, 1);
+
if (ret < 0)
- hid_err(hdev, "can't set operational mode\n");
+ hid_err(hdev, "can't set operational mode: step 3\n");
+out:
kfree(buf);
return ret;
--
1.8.3.1
next reply other threads:[~2015-02-16 13:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 13:06 Lauri Kasanen [this message]
2015-02-16 16:59 ` [PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers Antonio Ospite
2015-02-17 12:18 ` Jiri Kosina
2015-02-16 17:12 ` [PATCH 0/5] HID: sony: misc fixes and cleanups Antonio Ospite
2015-02-16 17:12 ` [PATCH 2/5] HID: sony: Use the minimum accepted size for feature report 0xf2 Antonio Ospite
2015-02-16 17:12 ` [PATCH 3/5] HID: sony: Don't use magic numbers in sixaxis_set_operational_usb() Antonio Ospite
2015-02-16 17:12 ` [PATCH 4/5] HID: sony: Use __u8 * for the buffer " Antonio Ospite
2015-02-16 17:12 ` [PATCH 5/5] HID: sony: Coding style cleanups " Antonio Ospite
2015-02-16 21:48 ` [PATCH 0/5] HID: sony: misc fixes and cleanups Frank Praznik
2015-02-16 22:29 ` Antonio Ospite
2015-02-16 21:58 ` [PATCH 1/5] HID: sony: Fix a WARNING shown when rmmod-ing the driver Antonio Ospite
2015-02-17 18:03 ` [PATCH 0/5] HID: sony: misc fixes and cleanups Frank Praznik
2015-02-18 20:41 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216150659.db522f3d.cand@gmx.com \
--to=cand@gmx.com \
--cc=AndrewD207@aol.com \
--cc=ao2@ao2.it \
--cc=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.