All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Hall <mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
To: Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org>
Cc: Dev <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: kernel: BUG: soft lockup - CPU#1 stuck for 22s! [kni_single:1782]
Date: Mon, 16 Feb 2015 17:00:24 -0800	[thread overview]
Message-ID: <20150217010024.GB30617@mhcomputing.net> (raw)
In-Reply-To: <CADNuJVpKGyFOKNA1JCVbg72SwPbM0+9HSWAHwAiG=G2AXFKJ-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Mon, Feb 16, 2015 at 10:33:52AM -0600, Jay Rolette wrote:
> In kni_net_rx_normal(), it was calling netif_receive_skb() instead of
> netif_rx(). The source for netif_receive_skb() point out that it should
> only be called from soft-irq context, which isn't the case for KNI.

For the uninitiated among us, what was the practical effect of the coding 
error? Waiting forever for a lock which will never be available in IRQ 
context, or causing unintended re-entrancy, or what?

Thanks,
Matthew.

  parent reply	other threads:[~2015-02-17  1:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  1:33 kernel: BUG: soft lockup - CPU#1 stuck for 22s! [kni_single:1782] Jay Rolette
     [not found] ` <CADNuJVpqB+kydPe1QXcLV21GRF-TMR9dkXdYysk7XTdBZryhcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-11 16:25   ` Alejandro Lucero
     [not found]     ` <CAD+H990A4UOw6qthPHfegdzyzcJOh+a8A9=HKeyp59niAgNBDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-16 13:32       ` Jay Rolette
2015-02-16 16:33   ` Jay Rolette
     [not found]     ` <CADNuJVpKGyFOKNA1JCVbg72SwPbM0+9HSWAHwAiG=G2AXFKJ-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-17  1:00       ` Matthew Hall [this message]
     [not found]         ` <20150217010024.GB30617-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org>
2015-02-17 15:57           ` Jay Rolette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150217010024.GB30617@mhcomputing.net \
    --to=mhall-hv3ognyu3jfzzajbqzqcxq@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.