From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNmbj-0007f2-No for qemu-devel@nongnu.org; Tue, 17 Feb 2015 13:10:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNmbg-0001io-Dh for qemu-devel@nongnu.org; Tue, 17 Feb 2015 13:10:51 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:55709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNmbg-0001iG-3i for qemu-devel@nongnu.org; Tue, 17 Feb 2015 13:10:48 -0500 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Feb 2015 11:10:45 -0700 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id A9C8A38C8046 for ; Tue, 17 Feb 2015 13:06:48 -0500 (EST) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1HIAfaK27328728 for ; Tue, 17 Feb 2015 18:10:41 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1HIAdWU012661 for ; Tue, 17 Feb 2015 13:10:40 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <54E35D94.2020209@redhat.com> References: <1424142892-7275-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424142892-7275-6-git-send-email-mdroth@linux.vnet.ibm.com> <54E35D94.2020209@redhat.com> Message-ID: <20150217181033.13315.15114@loki> Date: Tue, 17 Feb 2015 12:10:33 -0600 Subject: Re: [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, zhanghailiang Quoting Eric Blake (2015-02-17 09:26:12) > On 02/16/2015 08:14 PM, Michael Roth wrote: > > From: zhanghailiang > > = > > Introduce three new guest commands: > > guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-bloc= k-size. > = > Sorry for the late review, but I think guest-get-memory-block-size is > the wrong command to add. > = > = > > +## > > +# @guest-get-memory-block-size: > > +# > > +# Get the the size (in bytes) of a memory block in guest. > > +# It is the unit of memory block online/offline operation (also called= Logical > > +# Memory Hotplug). > > +# > > +# Returns: memory block size in bytes. > > +# > > +# Since 2.3 > > +## > > +{ 'command': 'guest-get-memory-block-size', > > + 'returns': 'int' } > = > Any QAPI command that returns a bare int instead of a dictionary is > non-extensible, and therefore of suspect design. I think it would be > better to have: > = > { 'command': 'guest-get-memory-block-info', > 'returns': { 'size': 'int' } } > = > to allow for future extension. It seems like a reasonable suggestion to me. I can change it in my tree if there are no objections. zhanghailiang? > = > -- = > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org