From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric B Munson <emunson@akamai.com>
Cc: netfilter-devel@vger.kernel.org, johunt@akamai.com,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: Re: [PATCH RESEND] Add element count to bitmap and hash headers
Date: Wed, 18 Feb 2015 04:54:16 +0100 [thread overview]
Message-ID: <20150218035416.GA4945@salvia> (raw)
In-Reply-To: <alpine.DEB.2.10.1502172223580.16817@blackhole.kfki.hu>
On Tue, Feb 17, 2015 at 10:35:40PM +0100, Jozsef Kadlecsik wrote:
> On Tue, 17 Feb 2015, Pablo Neira Ayuso wrote:
>
> > On Tue, Feb 17, 2015 at 10:35:35AM -0500, Eric B Munson wrote:
> > > It would be useful for userspace to query the size of an ipset. This
> > > data is held for both the bitmask and hash types, however, it is not
> > > exposed to userspace. This patch uses the otherwise unused attribute
> > > IPSET_ATTR_ELEMENTS to indicate the size in the the header that is
> > > exported to userspace.
> >
> > Thanks for your patch.
> >
> > I think Jozsef will need the userspace bits for his library and
> > utility.
>
> Yes, that's missing from the patch. Also, I don't like any change which
> affects the userspace but not expressed in new set type revision. Later on
> the new revision makes much simpler to identify why the "Elements: is
> missing from the listing of a set.
Please address Jozsef's feedback and resubmit. Thanks.
next prev parent reply other threads:[~2015-02-18 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 15:35 [PATCH RESEND] Add element count to bitmap and hash headers Eric B Munson
2015-02-17 15:53 ` Pablo Neira Ayuso
2015-02-17 21:35 ` Jozsef Kadlecsik
2015-02-18 3:54 ` Pablo Neira Ayuso [this message]
2015-02-18 14:59 ` Eric B Munson
2015-02-18 19:53 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218035416.GA4945@salvia \
--to=pablo@netfilter.org \
--cc=emunson@akamai.com \
--cc=johunt@akamai.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.