All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	Borislav Petkov <bp@suse.de>
Subject: Re: [GIT PULL] Fix mcelog regression
Date: Wed, 18 Feb 2015 07:41:35 +0100	[thread overview]
Message-ID: <20150218064135.GA9832@gmail.com> (raw)
In-Reply-To: <54e3b9d24385bb413@agluck-desk.sc.intel.com>


* Luck, Tony <tony.luck@intel.com> wrote:

> Sorry for bypassing normal channels, but this looks like 
> a trivial regression fix to me, but I'm getting pushback 
> from my co-maintainer and from Ingo.
> 
>   1. This used to work
>   2. Now it doesn't
>   3. People have complained
> 
> Previous threads:
>   https://lkml.org/lkml/2015/1/30/641
>   https://lkml.org/lkml/2015/2/11/437

So this fix is perfectly OK to me. The primary thing I 
objected to (which objection you did not quote!!), was the 
initial approach, the ugly vendor-specific switch you 
added:

    https://lkml.org/lkml/2015/2/9/237

The latest replacement commit you added looks clean - and 
/dev/mcelog is certainly a legacy we have to keep.

Thanks,

	Ingo

      reply	other threads:[~2015-02-18  6:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 21:59 [GIT PULL] Fix mcelog regression Luck, Tony
2015-02-18  6:41 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150218064135.GA9832@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@suse.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.