From: "Benoît Canet" <benoit.canet-J9ArbTHlV+bR7s880joybQ@public.gmane.org>
To: huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
dev-VfR2kkLFssw@public.gmane.org
Subject: Vhost-user early adopter feedback
Date: Wed, 18 Feb 2015 08:59:23 +0100 [thread overview]
Message-ID: <20150218075923.GA23117@irqsave.net> (raw)
Hello Xie,
As promized I integrated your vhost-user patchset from january in my vswitch.
I just tried it, it works pretty well.
I just had a minor bug with rte_vhost_driver_register taking ownership of the
string patch pointer too late. I freed it out of habit just after registering in the
caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I
allocated later. Maybe an early strdup() would fix this.
The last patch of your new version is really a great idea since it will
simplify a lot the socket creation and management code.
Best regards
Benoît
next reply other threads:[~2015-02-18 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 7:59 Benoît Canet [this message]
2015-02-25 7:46 ` Vhost-user early adopter feedback Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F3A436D-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-25 11:32 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218075923.GA23117@irqsave.net \
--to=benoit.canet-j9arbthlv+br7s880joybq@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.