From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Mueller Subject: Re: [Qemu-devel] [RFC PATCH v2 11/15] cpu-model/s390: Add QMP command query-cpu-model Date: Wed, 18 Feb 2015 09:39:59 +0100 Message-ID: <20150218093959.31982d1c@bee> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-12-git-send-email-mimu@linux.vnet.ibm.com> <54E3825F.7080701@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <54E3825F.7080701@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Eric Blake Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson List-ID: LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMQ0KDQpPbiBUdWUs IDE3IEZlYiAyMDE1IDExOjAzOjExIC0wNzAwDQpFcmljIEJsYWtlIDxlYmxha2VAcmVkaGF0LmNv bT4gd3JvdGU6DQoNCj4gT24gMDIvMTcvMjAxNSAwNzoyNCBBTSwgTWljaGFlbCBNdWVsbGVyIHdy b3RlOg0KPiA+IFRoaXMgcGF0Y2ggaW1wbGVtZW50cyBhIG5ldyBRTVAgcmVxdWVzdCBuYW1lZCAn cXVlcnktY3B1LW1vZGVsJy4NCj4gPiBJdCByZXR1cm5zIHRoZSBjcHUgbW9kZWwgb2YgY3B1IDAg YW5kIGl0cyBiYWNraW5nIGFjY2VsZXJhdG9yLg0KPiA+IA0KPiA+IHJlcXVlc3Q6DQo+ID4gICB7 ImV4ZWN1dGUiIDogInF1ZXJ5LWNwdS1tb2RlbCIgfQ0KPiA+IA0KPiA+IGFuc3dlcjoNCj4gPiAg IHsicmV0dXJuIiA6IHsibmFtZSI6ICIyODI3LWdhMiIsICJhY2NlbGVyYXRvciI6ICJrdm0iIH19 DQo+ID4gDQo+ID4gQWxpYXMgbmFtZXMgYXJlIHJlc29sdmVkIHRvIHRoZWlyIHJlc3BlY3RpdmUg bWFjaGluZSB0eXBlIGFuZCBHQSBuYW1lcw0KPiA+IGFscmVhZHkgZHVyaW5nIGNwdSBpbnN0YW50 aWF0aW9uLiBUaHVzLCBhbHNvIGEgY3B1IG1vZGVsIGxpa2UgJ2hvc3QnDQo+ID4gd2hpY2ggaXMg aW1wbGVtZW50ZWQgYXMgYWxpYXMgd2lsbCByZXR1cm4gaXRzIG5vcm1hbGl6ZWQgY3B1IG1vZGVs IG5hbWUuDQo+ID4gDQo+ID4gRnVydGhlcm1vcmUgdGhlIHBhdGNoIGltcGxlbWVudHMgdGhlIGZv bGxvd2luZyBmdW5jdGlvbnM6DQo+ID4gDQo+ID4gLSBzMzkwX2NwdV90eXBlbmFtZSgpLCByZXR1 cm5zIHRoZSBjdXJyZW50bHkgc2VsZWN0ZWQgY3B1IHR5cGUgbmFtZSBvciBOVUxMDQo+ID4gLSBz MzkwX2NwdV9tb2RlbHNfdXNlZCgpLCByZXR1cm5zIHRydWUgaWYgUzM5MCBjcHUgbW9kZWxzIGFy ZSBpbiB1c2UNCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWVsIE11ZWxsZXIgPG1pbXVA bGludXgudm5ldC5pYm0uY29tPg0KPiA+IC0tLQ0KPiA+ICANCj4gPiArIyMNCj4gPiArIyBAQ3B1 TW9kZWxJbmZvOg0KPiA+ICsjDQo+ID4gKyMgVmlydHVhbCBDUFUgbW9kZWwgZGVmaW5pdGlvbi4N Cj4gPiArIw0KPiA+ICsjIEBuYW1lOiB0aGUgbmFtZSBvZiB0aGUgQ1BVIG1vZGVsIGRlZmluaXRp b24NCj4gPiArIw0KPiA+ICsjIFNpbmNlOiAyLjMuMA0KPiA+ICsjIw0KPiA+ICt7ICd0eXBlJzog J0NwdU1vZGVsSW5mbycsDQo+ID4gKyAgJ2RhdGEnOiB7ICduYW1lJzogJ3N0cicsICcqYWNjZWxl cmF0b3InOiAnQWNjZWxJZCcgfSB9DQo+IA0KPiBZb3UgZGlkbid0IGRvY3VtZW50ICcqYWNjZWxl cmF0b3InLCBpbmNsdWRpbmcgbWVudGlvbiB0aGF0IGl0IGlzDQo+IG9wdGlvbmFsICh3aHkgd291 bGQgaXQgbm90IGJlIG91dHB1dCBhbHdheXM/KS4NCg0KUmlnaHQsIGFzIGl0IGlzIGEgbmV3IGNv bW1hbmQgYW5kIGFsbCBjcHVzIG9uY2UgaW1wbGVtZW50aW5nIGl0IGhhdmUgYW4gYXNzb2NpYXRl ZCBhY2NlbGVyYXRvcg0KdGhlcmUgaXMgbm8gcG9pbnQgaW4gbWFraW5nIGl0IG9wdGlvbmFsLiBX aWxsIGFkZCBhIGNvbW1lbnQgYXMgd2VsbC4NCj4gDQo+ID4gKw0KPiA+ICsjIw0KPiA+ICsjIEBx dWVyeS1jcHUtbW9kZWw6DQo+ID4gKyMNCj4gPiArIyBSZXR1cm4gdG8gY3VycmVudCB2aXJ0dWFs IENQVSBtb2RlbA0KPiANCj4gcy90by90aGUvDQoNCnllcA0KDQo+IA0KPiA+ICsjDQo+ID4gKyMg UmV0dXJuczogQ3B1TW9kZWxJbmZvDQo+ID4gKyMNCj4gPiArIyBTaW5jZTogMi4zLjANCj4gDQo+ IFdlIGFyZW4ndCB2ZXJ5IGNvbnNpc3RlbnQgb24gJzIuMycgdnMuICcyLjMuMCcsIHNvIEkgd29u J3QgY29tcGxhaW4NCj4gYWJvdXQgdGhhdC4NCg0KQnV0IHlvdSBzZWVtIHRvIHByZWZlciBtYWpv ciBhbmQgbWlub3Igb25seSwgc28gSSB3aWxsIHNraXAgdGhlIHRyYWlsaW5nIDAuDQoNCj4gDQo+ ID4gKyMjDQo+ID4gK3sgJ2NvbW1hbmQnOiAncXVlcnktY3B1LW1vZGVsJywgJ3JldHVybnMnOiAn Q3B1TW9kZWxJbmZvJyB9DQo+IA0KPiBTZWVtcyByZWFzb25hYmxlIGZyb20gdGhlIGludGVyZmFj ZSBwb2ludCBvZiB2aWV3OyBJIGhhdmUgbm90IGNsb3NlbHkNCj4gcmV2aWV3ZWQgdGhlIGltcGxl bWVudGF0aW9uLg0KPiANCg0KVGhhbmtzDQpNaWNoYWVsDQotLS0tLUJFR0lOIFBHUCBTSUdOQVRV UkUtLS0tLQ0KVmVyc2lvbjogR251UEcgdjENCg0KaVFJY0JBRUJBZ0FHQlFKVTVFL2ZBQW9KRUxQ Y1BMUVNKc0tRWWtzUC9pbldoY1NuUUY2V2dOVGFGMnFzRXF5Rw0KNmtSeUF3ZlZJRDlrMFJoMUVo M2ZES2JERHJ0WGUxcEIzZGJIbFg2SldXckRDUUN6ZkZ4YlJERWxLM2xYNGsxZw0KcnlBaTlaUlBa N1RCODhlR0lTNjZ2UTRKL085V1dlL0k3dHpvWDJ5ZUZjTVJOYTkrOGRweWx1UEhXTlliZU42Zg0K S2t6UXkxNVBhYkNpZ2d3UXVEZm0rWDRqaVY3SHRJZHhSVk51T0pWNGoyVThwNldwNVlhWk1FcDhN SlEydERNZQ0KVWlvbjkxVloyaXpMUS9ybitRSWIxRjI4b20wM0xXZmg0N3NLemFtOWw5b29tRmds R2htSFhrRWt0TCtLQ1FUSw0KTVNVUU9pSUszclN6WmlGcTVkc2pJQU9vMWJrcmpZcFB4VWZ4cTB4 RGpyZUpvR2tkMXNidFE2NjNRSEcwUlVUVA0KMUcwQk5LSHhOZ2dreG94eUNoYUVZV29wTnlaMndN RW4zWEJhVkh2bmZEcUR5eW1zV28zbkFRVldJTXdGcEh0aA0KdlNmQkxZM0NKbkFXNEhuRGlhVjMr c05EbEZabHR0elBFNWpWWGliUjk4c0NkUU9STkVwQ3Q5ZnJkdTFBVG9HQg0KTUNpQXdKTWMxcWVz Y0pNZ2hzb2dDVXpHOUVsQTd3YnZHSXYrZS91RUdqN0xCLzFIMFpNSXBOL1FVOU5EZDNGaQ0KWHBs ZEd2UExJV1JKcTcvbDhjNi9LTmc4U2JUbjFwcnRHWjFwS05PbGttbitCZUVRamNpaEVtR09TdG9X bnk0OA0KMWhUMDhlbmhCSjlza1h2V2xHVHZZQmxvaFE2dkVSd1o1QjlFNHRtU2VMUlFHKzRZa0Uz SlR5YjBGSkpTY0JvVg0KbDFYK1Btd2lUMkFmZVhMbERIbG0NCj02UW1pDQotLS0tLUVORCBQR1Ag U0lHTkFUVVJFLS0tLS0NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbbBRIkY (ORCPT ); Wed, 18 Feb 2015 03:40:24 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:42012 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbbBRIkT (ORCPT ); Wed, 18 Feb 2015 03:40:19 -0500 Date: Wed, 18 Feb 2015 09:39:59 +0100 From: Michael Mueller To: Eric Blake Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Alexander Graf , Christian Borntraeger , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Andreas Faerber , Richard Henderson Subject: Re: [Qemu-devel] [RFC PATCH v2 11/15] cpu-model/s390: Add QMP command query-cpu-model Message-ID: <20150218093959.31982d1c@bee> In-Reply-To: <54E3825F.7080701@redhat.com> References: <1424183053-4310-1-git-send-email-mimu@linux.vnet.ibm.com> <1424183053-4310-12-git-send-email-mimu@linux.vnet.ibm.com> <54E3825F.7080701@redhat.com> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15021808-0021-0000-0000-000002EF1E8F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t1I8eW3S022108 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, 17 Feb 2015 11:03:11 -0700 Eric Blake wrote: > On 02/17/2015 07:24 AM, Michael Mueller wrote: > > This patch implements a new QMP request named 'query-cpu-model'. > > It returns the cpu model of cpu 0 and its backing accelerator. > > > > request: > > {"execute" : "query-cpu-model" } > > > > answer: > > {"return" : {"name": "2827-ga2", "accelerator": "kvm" }} > > > > Alias names are resolved to their respective machine type and GA names > > already during cpu instantiation. Thus, also a cpu model like 'host' > > which is implemented as alias will return its normalized cpu model name. > > > > Furthermore the patch implements the following functions: > > > > - s390_cpu_typename(), returns the currently selected cpu type name or NULL > > - s390_cpu_models_used(), returns true if S390 cpu models are in use > > > > Signed-off-by: Michael Mueller > > --- > > > > +## > > +# @CpuModelInfo: > > +# > > +# Virtual CPU model definition. > > +# > > +# @name: the name of the CPU model definition > > +# > > +# Since: 2.3.0 > > +## > > +{ 'type': 'CpuModelInfo', > > + 'data': { 'name': 'str', '*accelerator': 'AccelId' } } > > You didn't document '*accelerator', including mention that it is > optional (why would it not be output always?). Right, as it is a new command and all cpus once implementing it have an associated accelerator there is no point in making it optional. Will add a comment as well. > > > + > > +## > > +# @query-cpu-model: > > +# > > +# Return to current virtual CPU model > > s/to/the/ yep > > > +# > > +# Returns: CpuModelInfo > > +# > > +# Since: 2.3.0 > > We aren't very consistent on '2.3' vs. '2.3.0', so I won't complain > about that. But you seem to prefer major and minor only, so I will skip the trailing 0. > > > +## > > +{ 'command': 'query-cpu-model', 'returns': 'CpuModelInfo' } > > Seems reasonable from the interface point of view; I have not closely > reviewed the implementation. > Thanks Michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU5E/fAAoJELPcPLQSJsKQYksP/inWhcSnQF6WgNTaF2qsEqyG 6kRyAwfVID9k0Rh1Eh3fDKbDDrtXe1pB3dbHlX6JWWrDCQCzfFxbRDElK3lX4k1g ryAi9ZRPZ7TB88eGIS66vQ4J/O9WWe/I7tzoX2yeFcMRNa9+8dpyluPHWNYbeN6f KkzQy15PabCiggwQuDfm+X4jiV7HtIdxRVNuOJV4j2U8p6Wp5YaZMEp8MJQ2tDMe Uion91VZ2izLQ/rn+QIb1F28om03LWfh47sKzam9l9oomFglGhmHXkEktL+KCQTK MSUQOiIK3rSzZiFq5dsjIAOo1bkrjYpPxUfxq0xDjreJoGkd1sbtQ663QHG0RUTT 1G0BNKHxNggkxoxyChaEYWopNyZ2wMEn3XBaVHvnfDqDyymsWo3nAQVWIMwFpHth vSfBLY3CJnAW4HnDiaV3+sNDlFZlttzPE5jVXibR98sCdQORNEpCt9frdu1AToGB MCiAwJMc1qescJMghsogCUzG9ElA7wbvGIv+e/uEGj7LB/1H0ZMIpN/QU9NDd3Fi XpldGvPLIWRJq7/l8c6/KNg8SbTn1prtGZ1pKNOlkmn+BeEQjcihEmGOStoWny48 1hT08enhBJ9skXvWlGTvYBlohQ6vERwZ5B9E4tmSeLRQG+4YkE3JTyb0FJJScBoV l1X+PmwiT2AfeXLlDHlm =6Qmi -----END PGP SIGNATURE----- {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I