From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: dm-mirror: do not degrade the mirror on discard error Date: Wed, 18 Feb 2015 13:21:19 -0500 Message-ID: <20150218182119.GA3029@redhat.com> References: <1423967994.19864.9.camel@HansenPartnership.com> <1424096844.2089.2.camel@HansenPartnership.com> <1424272616.2122.12.camel@HansenPartnership.com> <20150218171016.GA2032@redhat.com> <1424282047.2122.54.camel@HansenPartnership.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1424282047.2122.54.camel@HansenPartnership.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: James Bottomley Cc: Heinz Mauelshagen , dm-devel@redhat.com, Mikulas Patocka , "Alasdair G. Kergon" , Zdenek Kabelac List-Id: dm-devel.ids On Wed, Feb 18 2015 at 12:54pm -0500, James Bottomley wrote: > On Wed, 2015-02-18 at 12:10 -0500, Mike Snitzer wrote: > > > > Let's please set this thread to one side. I already offered my thoughts > > in this thread, see: > > https://www.redhat.com/archives/dm-devel/2015-February/msg00076.html > > > > I'm not interested in wiring up the actual error return for dm-mirror's > > benefit. If/when other dm-io consumers have a need to differentiate > > between error codes we'll fix dm-io as needed. > > Yep, concur ... the point I've been obviously failing to make is that > all the world is not an SSD. I agree, and am aware. The layers that have needed to worry about properly differentiating between these higher level returns from SCSI do (e.g. dm-mpath). But it is pretty rare for bio-based DM targets to differentiate between error codes. Not saying that is right, just that is how things stand. Could be there is room for improvement in places.