From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 3E9FBE00815; Thu, 19 Feb 2015 02:41:47 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 6FD38E0034A for ; Thu, 19 Feb 2015 02:41:44 -0800 (PST) Received: by mail.free-electrons.com (Postfix, from userid 106) id C401E122; Thu, 19 Feb 2015 11:41:43 +0100 (CET) Received: from localhost (128-79-216-6.hfc.dyn.abo.bbox.fr [128.79.216.6]) by mail.free-electrons.com (Postfix) with ESMTPSA id 82BEC90; Thu, 19 Feb 2015 11:41:43 +0100 (CET) Date: Thu, 19 Feb 2015 11:41:42 +0100 From: Alexandre Belloni To: Otavio Salvador Message-ID: <20150219104142.GF10602@piout.net> References: <1424177364-31179-1-git-send-email-otavio@ossystems.com.br> <1424177364-31179-4-git-send-email-otavio@ossystems.com.br> MIME-Version: 1.0 In-Reply-To: <1424177364-31179-4-git-send-email-otavio@ossystems.com.br> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: meta-freescale Mailing List Subject: Re: [meta-fsl-arm][PATCH 4/4] qtbase: Remove distribution-related settings X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 10:41:47 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi, I just want to mention that removing icu will break any application using qtwebkit (but not qtwebkit itself) when building with a distro that does not add icu to the qtbase PACKAGECONFIG (like poky). I'm not saying this shouldn't be done, I'm just warning that we may see some reports of broken applications soon ;) On 17/02/2015 at 10:49:24 -0200, Otavio Salvador wrote : > The use of TSLib, ICU and availability of examples is a distribution > configuration and not a BSP thing. Drop this settings from the > bbappend. > > Signed-off-by: Otavio Salvador > --- > qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend b/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend > index 64966c2..3152956 100644 > --- a/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend > +++ b/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend > @@ -1,3 +1,4 @@ > +# Copyright (C) 2013-2015 O.S. Systems Software LTDA. > # Copyright (C) 2013 Eric Bénard - Eukréa Electromatique > > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > @@ -10,17 +11,15 @@ IS_MX6SL = "0" > IS_MX6SL_mx6sl = "1" > > PACKAGECONFIG_GL_mx5 = "gles2" > -PACKAGECONFIG_append_mx5 = " tslib icu examples" > > PACKAGECONFIG_GL_mx6q = "gles2" > PACKAGECONFIG_GL_mx6dl = "gles2" > PACKAGECONFIG_GL_mx6sl = "${@base_contains('DISTRO_FEATURES', 'x11', \ > ' gl', '', d)}" > -PACKAGECONFIG_append_mx6 = " tslib icu examples" > QT_CONFIG_FLAGS_append_mx6q = "${@base_contains('DISTRO_FEATURES', 'x11', ' -no-eglfs', ' -eglfs', d)}" > QT_CONFIG_FLAGS_append_mx6dl = "${@base_contains('DISTRO_FEATURES', 'x11', ' -no-eglfs', ' -eglfs', d)}" > QT_CONFIG_FLAGS_append_mx6sl = "${@base_contains('DISTRO_FEATURES', 'x11', \ > - ' -no-eglfs', ' -no-opengl -linuxfb -no-icu -no-eglfs', d)}" > + ' -no-eglfs', ' -no-opengl -linuxfb -no-eglfs', d)}" > > do_configure_prepend_mx5() { > sed -i 's!load(qt_config)!!' ${S}/mkspecs/linux-oe-g++/qmake.conf > -- > 2.1.4 > > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com