From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org,
Stephen Hemminger
<shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 5/6] eal: remove useless memset
Date: Thu, 19 Feb 2015 14:58:57 +0000 [thread overview]
Message-ID: <20150219145857.GD700@bricha3-MOBL3> (raw)
In-Reply-To: <1423925950-5201-5-git-send-email-shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
On Sat, Feb 14, 2015 at 09:59:09AM -0500, Stephen Hemminger wrote:
> The path variable is set via snprintf, and does not need to
> memset before that.
>
> Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Acked-by: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> index 590cb56..8d29e06 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
> @@ -84,8 +84,6 @@ get_num_hugepages(const char *subdir)
> else
> nr_hp_file = "free_hugepages";
>
> - memset(path, 0, sizeof(path));
> -
> snprintf(path, sizeof(path), "%s/%s/%s",
> sys_dir_path, subdir, nr_hp_file);
>
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-02-19 14:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 14:59 [PATCH 1/6] test: remove unneeded casts Stephen Hemminger
[not found] ` <1423925950-5201-1-git-send-email-shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
2015-02-14 14:59 ` [PATCH 2/6] vhost_xen: remove unnecessary cast Stephen Hemminger
[not found] ` <1423925950-5201-2-git-send-email-shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
2015-02-19 14:53 ` Bruce Richardson
2015-02-14 14:59 ` [PATCH 3/6] bsd: remove useless assignments Stephen Hemminger
[not found] ` <1423925950-5201-3-git-send-email-shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
2015-02-16 11:31 ` Bruce Richardson
2015-02-14 14:59 ` [PATCH 4/6] enic: eliminate useless cast Stephen Hemminger
[not found] ` <1423925950-5201-4-git-send-email-shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
2015-02-19 14:57 ` Bruce Richardson
2015-02-14 14:59 ` [PATCH 5/6] eal: remove useless memset Stephen Hemminger
[not found] ` <1423925950-5201-5-git-send-email-shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
2015-02-19 14:58 ` Bruce Richardson [this message]
2015-02-14 14:59 ` [PATCH 6/6] examples: remove unneeded casts Stephen Hemminger
[not found] ` <1423925950-5201-6-git-send-email-shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
2015-02-19 15:02 ` Bruce Richardson
2015-02-19 14:53 ` [PATCH 1/6] test: " Bruce Richardson
2015-03-04 20:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219145857.GD700@bricha3-MOBL3 \
--to=bruce.richardson-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.