From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by mail.openembedded.org (Postfix) with ESMTP id 2B6186B6B7 for ; Thu, 19 Feb 2015 16:14:17 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id h11so49177831wiw.3 for ; Thu, 19 Feb 2015 08:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=1+Acac9d3HfFf9KFORTqHq2p2HORmuXtF2RcX00cdfc=; b=X7UNYnNlQ/jg5dW34BVMowbhIFThmqWzPnMWXkWOCPeCM1ycEsHWvC4HJWq6rjfTGL kpyRFpaaqli0uQUIukxipBhd8SePxha8dAIH+uIQgt235PQxqedzrvHo/FbmsRKsnc09 KoBNtXPnMkXbsLyhqNmZxQj8K/3N5k+ZoLu4JDL2v2Kcvu1RvnY9Ojjb/ScyIGIajoAR udZB3KhtGikdi8tO50rZDlWPG6BZUmOPZ44y+eU35TOslrT3Q7O3W6LxqGAG+7VtMGC0 OshC2Cd4oh1MRkliKybD1EekaB6ucWjjeVXYoV+LmxkKWQSOU8gO0OB0778PWe1LqTKg aVuw== X-Received: by 10.180.74.111 with SMTP id s15mr11269511wiv.61.1424362458852; Thu, 19 Feb 2015 08:14:18 -0800 (PST) Received: from localhost (ip-89-176-104-3.net.upcbroadband.cz. [89.176.104.3]) by mx.google.com with ESMTPSA id n3sm38016910wja.36.2015.02.19.08.14.17 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Feb 2015 08:14:18 -0800 (PST) From: Martin Jansa X-Google-Original-From: Martin Jansa Date: Thu, 19 Feb 2015 17:14:22 +0100 To: openembedded-devel@lists.openembedded.org Message-ID: <20150219161422.GD2311@jama> References: <1422338033-18521-1-git-send-email-schnitzeltony@googlemail.com> <1422338033-18521-2-git-send-email-schnitzeltony@googlemail.com> <20150218160919.GB2276@jama> <20150219144746.GB2311@jama> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [meta-qt5][PATCH 1/5] qtbase: remove patches required for native(-sdk) only X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 16:14:18 -0000 X-Groupsio-MsgNum: 54407 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pZs/OQEoSSbxGlYw" Content-Disposition: inline --pZs/OQEoSSbxGlYw Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 19, 2015 at 04:30:17PM +0100, Andreas M=FCller wrote: > On Thu, Feb 19, 2015 at 3:47 PM, Martin Jansa wr= ote: > > On Wed, Feb 18, 2015 at 06:35:33PM +0100, Andreas M=FCller wrote: > >> On Wed, Feb 18, 2015 at 5:09 PM, Martin Jansa = wrote: > >> > On Tue, Jan 27, 2015 at 06:53:49AM +0100, Andreas M=FCller wrote: > >> >> Signed-off-by: Andreas M=FCller > >> > > >> > Are you sure these are useful only for native(sdk) only? > >> > > >> > FYI: I'm updating your patches for latest revision in 5.4 branch, I'= ll > >> > update them together with 5.4.1 recipes (when 5.4.1 is released). > >> > > >> > Regards, > >> > > >> >> --- > >> >> recipes-qt/qt5/qtbase.inc | 2 -- > >> >> recipes-qt/qt5/qtbase_git.bb | 2 -- > >> >> 2 files changed, 4 deletions(-) > >> >> > >> >> diff --git a/recipes-qt/qt5/qtbase.inc b/recipes-qt/qt5/qtbase.inc > >> >> index 5b2c08c..a8748ef 100644 > >> >> --- a/recipes-qt/qt5/qtbase.inc > >> >> +++ b/recipes-qt/qt5/qtbase.inc > >> >> @@ -5,8 +5,6 @@ SRC_URI +=3D "\ > >> >> file://0001-Add-linux-oe-g-platform.patch \ > >> >> file://0002-qlibraryinfo-allow-to-set-qt.conf-from-the-outside= -u.patch \ > >> >> file://0003-Add-external-hostbindir-option.patch \ > >> >> - file://0004-configureapp-Prefix-default-LIBDIRS-and-INCDIRS-wi= th.patch \ > >> >> - file://0005-qt_module-Fix-pkgconfig-and-libtool-replacements.p= atch \ > >> >> file://0006-Revert-eglfs-Print-the-chosen-config-in-debug-mode= =2Epatch \ > >> >> file://0007-qeglplatformintegration-Undefine-CursorShape-from-= X..patch \ > >> >> file://0008-configure-bump-path-length-from-256-to-512-charact= er.patch \ > >> >> diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_g= it.bb > >> >> index f67ea16..611e19a 100644 > >> >> --- a/recipes-qt/qt5/qtbase_git.bb > >> >> +++ b/recipes-qt/qt5/qtbase_git.bb > >> >> @@ -10,8 +10,6 @@ SRC_URI +=3D "\ > >> >> file://0001-Add-linux-oe-g-platform.patch \ > >> >> file://0002-qlibraryinfo-allow-to-set-qt.conf-from-the-outside= -u.patch \ > >> >> file://0003-Add-external-hostbindir-option.patch \ > >> >> - file://0004-configureapp-Prefix-default-LIBDIRS-and-INCDIRS-wi= th.patch \ > >> >> - file://0005-qt_module-Fix-pkgconfig-and-libtool-replacements.p= atch \ > >> >> file://0006-Revert-eglfs-Print-the-chosen-config-in-debug-mode= =2Epatch \ > >> >> file://0007-qeglplatformintegration-Undefine-CursorShape-from-= X..patch \ > >> >> file://0008-configure-bump-path-length-from-256-to-512-charact= er.patch \ > >> >> -- > >> >> 1.8.3.1 > >> >> > >> >> -- > >> >> _______________________________________________ > >> >> Openembedded-devel mailing list > >> >> Openembedded-devel@lists.openembedded.org > >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > >> > > >> > -- > >> > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > >> > > >> First of all thanks for doing this: I have these patches on my TODO > >> but have other issues of higher priorities (ask my boss) to fix. > > > > In the end the fix was simple.. > > 0011-qmake-don-t-build-it-in-configure-but-allow-to-build.patch > > wasn't refreshed in qtbase-git directory, now it builds fine, I'll push > > it to master soon. > > > >> Answering your question frankly: No I am not 100% sure these patches > >> can be removed from target build.. > >> > >> * 0004-configureapp-Prefix-default-LIBDIRS-and-INCDIRS-with.patch: If > >> I don't go wrong here configureapp is the windows-replacement for > >> configure script -> this patch is not needed AT ALL (except we build > >> for windows which we usually don't). > > > > Ah right, it was looking a bit different at 5.0.0 version and now after > > many rebases it really looks useless, will drop with 5.4.1 (and now in > > git recipe). > > > >> * 0005-qt_module-Fix-pkgconfig-and-libtool-replacements.patch: > >> Intention here was to keep target sysroot clean of host paths - as > >> this patch was part qt-creator series. Raphael Philipe reported > >> failures for -L/usr/lib when building qt5-creator I'd suggest to keep > >> this patch in. > > > > OK, thanks. > > > > I've refreshed b5.4-shared b5.4-native b5.4-nativesdk b5.4-target > > branches at https://github.com/meta-qt5/qtbase this will be used to > > refresh patches for 5.4.1 recipes. > > > > -- > Ehm - I checked at github but I don't really look though the branch > systematics. As 5.4.1 is near and I have tons of KDE/Hawai/LxQt stuff > around for build test: Which branch should I use (qt/git-versions > enabled)? b5.4 is 5.4 branch from upstream without any modifications (just to remembe= r my base revision) \ \ b5.4-shared (patches shared by target, native, nativesdk qtbase) | \ b5.4-target (patches only for target qtbase) | \ b5.4-native (patches shared by native and nativesdk) \ \b5.4-nativesdk (patches only for nativesdk) so to refresh meta-qt5 patches I use: git format-patch origin/5.4..b5.4-nativesdk git format-patch origin/5.4..b5.4-target mv 00* ~/meta-qt5/recipes-qt/qt5/qtbase-git/ meta-qt5/master-next (and jansa/master) now contain your changes with qtbase/qtdeclarative upgrade/fix on top. You just need to set P_V like this: QT5_VERSION =3D "5.4.0+git%" require conf/distro/include/qt5-versions.inc --=20 Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com --pZs/OQEoSSbxGlYw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTmC94ACgkQN1Ujt2V2gBxuDwCfVYydFtk7gtLRE/Z5KDzWZH1W Dc0An0NnQ8NILSUk9nn2J5Ie7vYWWjZy =6v4Z -----END PGP SIGNATURE----- --pZs/OQEoSSbxGlYw--