All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Stephane Eranian <eranian@google.com>,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Pawel Moll <pawel.moll@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 0/2] perf/x86: Add ability to sample TSC
Date: Thu, 19 Feb 2015 20:13:21 +0100	[thread overview]
Message-ID: <20150219191321.GA12008@gmail.com> (raw)
In-Reply-To: <54E607AE.8080707@intel.com>


* Adrian Hunter <adrian.hunter@intel.com> wrote:

> > I suspect you're talking about something else entirely; 
> > your changelogs are inadequate for they tell ntohing of 
> > your usecase and have me guessing. Don't do that.
> 
> Sorry. I did mention Intel PT in patch 2, but I basically 
> assumed the need to synchronize events with other time 
> sources was understood.

Written down, slightly repetitive walk-throughs from first 
concepts to implementation that don't assume too much 
context are very useful to us slightly overworked 
maintainers with an attention span of a slightly retarded 
golden retriever. (Make the story interesting and mix in a 
few jokes and you've got our attention for sure!)

So please do explain verbosely, especially if a review 
discussion turns somewhat discordant, it's a useful tool.

Thanks,

	Ingo

  reply	other threads:[~2015-02-19 19:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 12:11 [PATCH 0/2] perf/x86: Add ability to sample TSC Adrian Hunter
2015-02-19 12:11 ` [PATCH 1/2] perf: Sample additional clock value Adrian Hunter
2015-02-19 12:11 ` [PATCH 2/2] perf/x86: Provide TSC for PERF_SAMPLE_CLOCK_ARCH Adrian Hunter
2015-02-19 13:50 ` [PATCH 0/2] perf/x86: Add ability to sample TSC Peter Zijlstra
2015-02-19 14:38   ` Adrian Hunter
2015-02-19 15:05     ` Peter Zijlstra
2015-02-19 15:56       ` Adrian Hunter
2015-02-19 19:13         ` Ingo Molnar [this message]
2015-02-19 17:41     ` Andi Kleen
2015-02-19 17:24 ` John Stultz
2015-02-19 17:40   ` Adrian Hunter
2015-02-19 17:50     ` John Stultz
2015-02-19 17:58       ` Pawel Moll
2015-02-19 18:01         ` Pawel Moll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150219191321.GA12008@gmail.com \
    --to=mingo@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=pawel.moll@arm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.