From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Hicks Subject: [PATCH] sata-fsl: Apply link speed limits Date: Thu, 19 Feb 2015 15:05:47 -0500 Message-ID: <20150219200547.GA25730@darwin.bork.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Scott Wood , Kumar Gala Cc: linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: linux-ide@vger.kernel.org CgpUaGUgZHJpdmVyIHdhcyBpZ25vcmluZyBsaW1pdHMgcmVxdWVzdGVkIGJ5IGxpYmF0YS5mb3Jj ZS4gIFRoZSBvdXRwdXQKd291bGQgbG9vayBsaWtlOgoKZnNsLXNhdGEgZmZlMTgwMDAuc2F0YTog U2F0YSBGU0wgUGxhdGZvcm0vQ1NCIERyaXZlciBpbml0CmF0YTE6IEZPUkNFOiBQSFkgc3BkIGxp bWl0IHNldCB0byAxLjVHYnBzCmF0YTE6IFNBVEEgbWF4IFVETUEvMTMzIGlycSA3NAphdGExOiBT aWduYXR1cmUgVXBkYXRlIGRldGVjdGVkIEAgMCBtc2VjcwphdGExOiBTQVRBIGxpbmsgdXAgMy4w IEdicHMgKFNTdGF0dXMgMTIzIFNDb250cm9sIDMxMCkKClNpZ25lZC1vZmYtYnk6IE1hcnRpbiBI aWNrcyA8bW9ydEBib3JrLm9yZz4KLS0tCiBkcml2ZXJzL2F0YS9zYXRhX2ZzbC5jIHwgICAgMiAr KwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMv YXRhL3NhdGFfZnNsLmMgYi9kcml2ZXJzL2F0YS9zYXRhX2ZzbC5jCmluZGV4IGY5MDU0Y2QuLmE5 YjU1MDggMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvYXRhL3NhdGFfZnNsLmMKKysrIGIvZHJpdmVycy9h dGEvc2F0YV9mc2wuYwpAQCAtODY4LDYgKzg2OCw4IEBAIHRyeV9vZmZsaW5lX2FnYWluOgogCSAq IFBIWSByZXNldCBzaG91bGQgcmVtYWluIGFzc2VydGVkIGZvciBhdGxlYXN0IDFtcwogCSAqLwog CWF0YV9tc2xlZXAoYXAsIDEpOworCQorCXNhdGFfc2V0X3NwZChsaW5rKTsKIAogCS8qCiAJICog Tm93LCBicmluZyB0aGUgaG9zdCBjb250cm9sbGVyIG9ubGluZSBhZ2FpbiwgdGhpcyBjYW4gdGFr ZSB0aW1lCi0tIAoxLjcuMTAuNAoKCi0tIApNYXJ0aW4gSGlja3MgUC5FbmcuICAgIHwgICAgICBt b3J0QGJvcmsub3JnCkJvcmsgQ29uc3VsdGluZyBJbmMuICAgfCAgKzEgKDYxMykgMjY2LTIyOTYK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMt ZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xp c3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from darwin.bork.org (darwin.bork.org [IPv6:2001:470:1f05:998::1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CFD6B1A0D7A for ; Fri, 20 Feb 2015 07:05:53 +1100 (AEDT) Date: Thu, 19 Feb 2015 15:05:47 -0500 From: Martin Hicks To: Scott Wood , Kumar Gala Subject: [PATCH] sata-fsl: Apply link speed limits Message-ID: <20150219200547.GA25730@darwin.bork.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , The driver was ignoring limits requested by libata.force. The output would look like: fsl-sata ffe18000.sata: Sata FSL Platform/CSB Driver init ata1: FORCE: PHY spd limit set to 1.5Gbps ata1: SATA max UDMA/133 irq 74 ata1: Signature Update detected @ 0 msecs ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 310) Signed-off-by: Martin Hicks --- drivers/ata/sata_fsl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index f9054cd..a9b5508 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -868,6 +868,8 @@ try_offline_again: * PHY reset should remain asserted for atleast 1ms */ ata_msleep(ap, 1); + + sata_set_spd(link); /* * Now, bring the host controller online again, this can take time -- 1.7.10.4 -- Martin Hicks P.Eng. | mort@bork.org Bork Consulting Inc. | +1 (613) 266-2296