Re: [PATCH] ipsecmgr: Add recipes for ipsec manager kernel module and libraries

[Denys Dmytriyenko <denys@ti.com>]

Sorry for the delay.

Overall looks good. See below.


On Tue, Feb 10, 2015 at 05:08:36PM -0500, Sam Nelson wrote:
> - Provides module and libraries to offload IPSec security
>  policy & associated security association to NETCP for
>  crypto operations
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  .../recipes-support/ipsecmgr/ipsecmgr-mod_git.bb   |   20 +++++++++++++
>  .../recipes-support/ipsecmgr/ipsecmgr.inc          |    6 ++++
>  .../recipes-support/ipsecmgr/ipsecmgr_git.bb       |   30 ++++++++++++++++++++
>  3 files changed, 56 insertions(+)
>  create mode 100644 meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr-mod_git.bb
>  create mode 100644 meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr.inc
>  create mode 100644 meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr_git.bb
> 
> diff --git a/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr-mod_git.bb b/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr-mod_git.bb
> new file mode 100644
> index 0000000..b00da58
> --- /dev/null
> +++ b/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr-mod_git.bb
> @@ -0,0 +1,20 @@
> +SUMMARY = "IPSec Manager kernel module"
> +DESCRIPTION = "Provides Module to offload IPSec security policy & associated security association to NETCP for crypto operations"
> +
> +LIC_FILES_CHKSUM = "file://../../ipsecmgr_snoop.h;beginline=1;endline=33;md5=f7eadca4fb5599f508dc11fa1e752919"
> +
> +include ipsecmgr.inc
> +
> +MACHINE_KERNEL_PR_append = "a+gitr${SRCPV}"
> +PR = "${MACHINE_KERNEL_PR}"
> +
> +EXTRA_OEMAKE += "KDIR="${STAGING_KERNEL_DIR}""
> +
> +inherit module
> +
> +S = "${WORKDIR}/git/src/module"
> +
> +do_install() {
> +# Install kernel module
> +	oe_runmake INSTALL_MOD_PATH="${D}" install
> +}
> diff --git a/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr.inc b/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr.inc
> new file mode 100644
> index 0000000..2aafa57
> --- /dev/null
> +++ b/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr.inc
> @@ -0,0 +1,6 @@
> +LICENSE = "BSD-3-Clause"
> +BRANCH="master"
> +SRC_URI = "git://arago-project.org/git/projects/ipsecmgr.git;protocol=git;branch=${BRANCH}"
> +#Commit ID corresponding to DEV.IPSECMGR.01.01.00.03
> +SRCREV = "1ea8355ae9142311901c842c97a58d2846b308e6"
> +PV     = "01.01.00.03"
> diff --git a/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr_git.bb b/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr_git.bb
> new file mode 100644
> index 0000000..790f7cb
> --- /dev/null
> +++ b/meta-arago-extras/recipes-support/ipsecmgr/ipsecmgr_git.bb
> @@ -0,0 +1,30 @@
> +SUMMARY = "IPSec Manager libraries"
> +DESCRIPTION = "Provides library to offload IPSec security policy & associated security association to NETCP for crypto operations"
> +
> +LIC_FILES_CHKSUM = "file://../ipsecmgr_snoop.h;beginline=1;endline=33;md5=f7eadca4fb5599f508dc11fa1e752919"
> +
> +include ipsecmgr.inc
> +
> +DEPENDS = "libnl-xfrm"
> +
> +CFLAGS += "-I${STAGING_INCDIR}/libnl3"
> +
> +S = "${WORKDIR}/git/build"
> +LIB_INC_DIR = "${S}/.."
> +UTILS_LIB_INC_DIR = "${S}/../utils/iface/"

Just a tiny nitpick - can you avoid using relative path "${S}/.." in the above 
paths by using "${WORKDIR}/git" instead?


> +
> +do_compile() {
> +# Compile the library
> +	make clean
> +	make all
> +}
> +do_install() {
> +# Install libraries
> +	install -d ${D}${libdir}/
> +	install -c -m 666 libipsecmgr_snoop.a ${D}${libdir}/
> +	install -c -m 666 libipsecmgr_ipc.a ${D}${libdir}/
> +	install -c -m 666 libipsecmgr_syslog.a ${D}${libdir}/
> +	install -d ${D}${includedir}/
> +	install -c -m 666 ${LIB_INC_DIR}/*.h ${D}${includedir}/
> +	install -c -m 666 ${UTILS_LIB_INC_DIR}/*.h ${D}${includedir}/
> +}
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago