From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Welling Subject: Re: [Patch v6 0/2] gpio: add GPIO hogging mechanism Date: Thu, 19 Feb 2015 15:46:39 -0600 Message-ID: <20150219214639.GB8656@deathray> References: <20150218172341.GA3851@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150218172341.GA3851-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benoit Parrot Cc: Linus Walleij , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexandre Courbot , Maxime Ripard , Jiri Prchal , Pantelis Antoniou List-Id: linux-gpio@vger.kernel.org On Wed, Feb 18, 2015 at 11:23:42AM -0600, Benoit Parrot wrote: > Gentle ping. > > Is there any chance this will make it in 3.21? > > Benoit > Is there a reason that the pin has to be "hogged"? Couldn't the pin be released after configuration for eventual use in the userspace? > Parrot, Benoit wrote on Wed [2015-Feb-02 17:44:43 -0600]: > > This patch set re-introduces the gpio hogging concept first > > presented by Boris Brezillion. > > This patch set provides a way to initially configure specific GPIO > > when the GPIO controller is probed. > > > > The actual DT scanning to collect the GPIO specific data is performed > > as part of of_gpiochip_add(). > > > > The purpose of this is to allow specific GPIOs to be configured > > without any driver specific code. > > This is particularly useful because board design are getting > > increasingly complex and given SoC pins can now have more > > than 10 mux values a lot of connections are now dependent on > > external IO muxes to switch various modes. > > > > Specific drivers should not necessarily need to be aware of > > what accounts to a specific board implementation. This board level > > "description" should be best kept as part of the dts file. > > > > Changes since v5: > > * Addressed review comment from Linus Walleij > > * Replace "state" property back with separate boolean properties > > * Renamed helper function > > * Refactored pr_* calls to remove "__func__" > > > > Changes since v4: > > * Addressed review comments from Alexandre Courbot > > > > Changes since v3: > > * Relocated the non-DT "hog" function to gpiolib.c. > > * Rename some of the function to be clearer and remove _ prefixes. > > * Replace the gpiod_request/gpiod_put usage with > > gpiochip_request_own_desc/free_own_desc version instead. > > * Refactor some of the logic to better handle error condition/reporting > > * Renamed the "direction" DT properties to "state". > > > > Changes since v2: > > * Refactor the gpio-hog mechanism to split the DT related action > > from the actual "hogging" operation. > > * This allows non-DT providers to implement hogs as well. > > * Added FLAG_IS_HOGGED to mark hogged gpio and make gpiochip removal > > able to release hogged gpio. > > * Similarly to the hogging, the cleanup is performed as part of > > of_gpiochip_remove > > > > Changes since v1: > > * Split the devicetree bindings documentation in its own patch. > > * Refactor the gpio-hog mechanism as private functions meant to > > be to invoked from of_gpiochip_add(). > > > > > > Benoit Parrot (2): > > gpio: add GPIO hogging mechanism > > gpio: Document GPIO hogging mechanism > > > > Documentation/devicetree/bindings/gpio/gpio.txt | 30 ++++++ > > drivers/gpio/gpiolib-of.c | 111 +++++++++++++++++++++ > > drivers/gpio/gpiolib.c | 124 ++++++++++++++++++++---- > > drivers/gpio/gpiolib.h | 3 + > > 4 files changed, 249 insertions(+), 19 deletions(-) > > > > -- > > 1.8.5.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbbBSVqq (ORCPT ); Thu, 19 Feb 2015 16:46:46 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:41888 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbbBSVqo (ORCPT ); Thu, 19 Feb 2015 16:46:44 -0500 Date: Thu, 19 Feb 2015 15:46:39 -0600 From: Michael Welling To: Benoit Parrot Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexandre Courbot , Maxime Ripard , Jiri Prchal , Pantelis Antoniou Subject: Re: [Patch v6 0/2] gpio: add GPIO hogging mechanism Message-ID: <20150219214639.GB8656@deathray> References: <20150218172341.GA3851@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150218172341.GA3851@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 18, 2015 at 11:23:42AM -0600, Benoit Parrot wrote: > Gentle ping. > > Is there any chance this will make it in 3.21? > > Benoit > Is there a reason that the pin has to be "hogged"? Couldn't the pin be released after configuration for eventual use in the userspace? > Parrot, Benoit wrote on Wed [2015-Feb-02 17:44:43 -0600]: > > This patch set re-introduces the gpio hogging concept first > > presented by Boris Brezillion. > > This patch set provides a way to initially configure specific GPIO > > when the GPIO controller is probed. > > > > The actual DT scanning to collect the GPIO specific data is performed > > as part of of_gpiochip_add(). > > > > The purpose of this is to allow specific GPIOs to be configured > > without any driver specific code. > > This is particularly useful because board design are getting > > increasingly complex and given SoC pins can now have more > > than 10 mux values a lot of connections are now dependent on > > external IO muxes to switch various modes. > > > > Specific drivers should not necessarily need to be aware of > > what accounts to a specific board implementation. This board level > > "description" should be best kept as part of the dts file. > > > > Changes since v5: > > * Addressed review comment from Linus Walleij > > * Replace "state" property back with separate boolean properties > > * Renamed helper function > > * Refactored pr_* calls to remove "__func__" > > > > Changes since v4: > > * Addressed review comments from Alexandre Courbot > > > > Changes since v3: > > * Relocated the non-DT "hog" function to gpiolib.c. > > * Rename some of the function to be clearer and remove _ prefixes. > > * Replace the gpiod_request/gpiod_put usage with > > gpiochip_request_own_desc/free_own_desc version instead. > > * Refactor some of the logic to better handle error condition/reporting > > * Renamed the "direction" DT properties to "state". > > > > Changes since v2: > > * Refactor the gpio-hog mechanism to split the DT related action > > from the actual "hogging" operation. > > * This allows non-DT providers to implement hogs as well. > > * Added FLAG_IS_HOGGED to mark hogged gpio and make gpiochip removal > > able to release hogged gpio. > > * Similarly to the hogging, the cleanup is performed as part of > > of_gpiochip_remove > > > > Changes since v1: > > * Split the devicetree bindings documentation in its own patch. > > * Refactor the gpio-hog mechanism as private functions meant to > > be to invoked from of_gpiochip_add(). > > > > > > Benoit Parrot (2): > > gpio: add GPIO hogging mechanism > > gpio: Document GPIO hogging mechanism > > > > Documentation/devicetree/bindings/gpio/gpio.txt | 30 ++++++ > > drivers/gpio/gpiolib-of.c | 111 +++++++++++++++++++++ > > drivers/gpio/gpiolib.c | 124 ++++++++++++++++++++---- > > drivers/gpio/gpiolib.h | 3 + > > 4 files changed, 249 insertions(+), 19 deletions(-) > > > > -- > > 1.8.5.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html