All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] btrfs-progs: fix static build with gettext
Date: Fri, 20 Feb 2015 00:04:00 +0200	[thread overview]
Message-ID: <20150219220400.GP2937@tarshish> (raw)
In-Reply-To: <20150219225818.63fccb6f@free-electrons.com>

Hi Thomas,

On Thu, Feb 19, 2015 at 10:58:18PM +0100, Thomas Petazzoni wrote:
> On Tue, 17 Feb 2015 14:20:44 +0200, Baruch Siach wrote:
> > gettext needs -pthread. Incidentally this change was also made in the package
> > Makefile itself for a different reason.
> > 
> > Also, drop -lm to match upstream change.
> > 
> > Fixes:
> > http://autobuild.buildroot.net/results/a53/a53f31355e955c734010922b47084605e13708ef/
> > http://autobuild.buildroot.net/results/43d/43deeeda31d9750b37e1f1058c3313a387843bee/
> > 
> > and more.
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> >  package/btrfs-progs/btrfs-progs.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks!
> 
> > -BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lm -lz -llzo2 -L. -lintl"
> > +BTRFS_PROGS_MAKE_FLAGS += lib_LIBS="-luuid -lblkid -lz -llzo2 -L. -lintl -pthread"
> 
> This is really ugly, because we have to duplicate the lib_LIBS value
> from the package Makefile, and whenever it gets changed in the package
> Makefile, we need to remember to also change it here. Not great :-/

This is temporary. Upstream switched to autotools for the next version (now at 
v3.19-rc2). Once we upgrade the usual LIBS= trick would be enough, I believe.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-02-19 22:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 12:20 [Buildroot] [PATCH] btrfs-progs: fix static build with gettext Baruch Siach
2015-02-19 21:58 ` Thomas Petazzoni
2015-02-19 22:04   ` Baruch Siach [this message]
2015-02-19 22:05     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150219220400.GP2937@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.