From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Rabin Vincent <rabin@rab.in>
Cc: Jesper Nilsson <jespern@axis.com>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] CRISv32: don't enable irqs in INIT_THREAD
Date: Fri, 20 Feb 2015 01:27:55 +0100 [thread overview]
Message-ID: <20150220002755.GA11399@axis.com> (raw)
In-Reply-To: <1424374196-4954-1-git-send-email-rabin@rab.in>
On Thu, Feb 19, 2015 at 08:29:51PM +0100, Rabin Vincent wrote:
> INIT_THREAD enables interrupts in the thread_struct's saved flags. This
> means that interrupts get enabled in the middle of context_switch()
> while switching to new tasks that get forked off the init task during
> boot. Don't do this.
>
> Fixes the following splat on boot with spinlock debugging on:
>
> BUG: spinlock cpu recursion on CPU#0, swapper/2
> lock: runqueues+0x0/0x47c, .magic: dead4ead, .owner: swapper/0,
> .owner_cpu: 0
> CPU: 0 PID: 2 Comm: swapper Not tainted 3.19.0-08796-ga747b55 #285
>
> Call Trace:
> [<c0032b80>] spin_bug+0x2a/0x36
> [<c0032c98>] do_raw_spin_lock+0xa2/0x126
> [<c01964b0>] _raw_spin_lock+0x20/0x2a
> [<c00286c8>] scheduler_tick+0x22/0x76
> [<c003db2c>] update_process_times+0x5e/0x72
> [<c0007a94>] timer_interrupt+0x4e/0x6a
> [<c00378d6>] handle_irq_event_percpu+0x54/0xf2
> [<c00379c4>] handle_irq_event+0x50/0x74
> [<c003988e>] handle_simple_irq+0x6c/0xbe
> [<c0037270>] generic_handle_irq+0x2a/0x36
> [<c0004c40>] do_IRQ+0x38/0x84
> [<c000662e>] crisv32_do_IRQ+0x54/0x60
> [<c0006204>] IRQ0x4b_interrupt+0x34/0x3c
> [<c0192baa>] __schedule+0x24a/0x532
> [<c00056b4>] ret_from_kernel_thread+0x0/0x14
>
> Signed-off-by: Rabin Vincent <rabin@rab.in>
Looks good, adding to the CRIS-tree.
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2015-02-20 0:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 19:29 [PATCH 1/6] CRISv32: don't enable irqs in INIT_THREAD Rabin Vincent
2015-02-19 19:29 ` [PATCH 2/6] CRIS: remove SMP code Rabin Vincent
2015-02-20 0:06 ` Paul Bolle
2015-02-20 5:05 ` Mikael Starvik
2015-02-21 0:40 ` Rabin Vincent
2015-02-21 9:14 ` Paul Bolle
2015-02-20 0:33 ` Jesper Nilsson
2015-02-19 19:29 ` [PATCH 3/6] CRIS: use generic atomic bitops Rabin Vincent
2015-02-20 0:28 ` Jesper Nilsson
2015-02-22 20:07 ` [PATCH] CRISv10: remove redundant macros from system.h Rabin Vincent
2015-02-19 19:29 ` [PATCH 4/6] CRIS: use generic atomic.h Rabin Vincent
2015-02-20 0:32 ` Jesper Nilsson
2015-02-19 19:29 ` [PATCH 5/6] CRIS: use generic cmpxchg.h Rabin Vincent
2015-02-20 0:30 ` Jesper Nilsson
2015-02-19 19:29 ` [PATCH 6/6] CRIS: use generic headers via Kbuild Rabin Vincent
2015-02-20 0:30 ` Jesper Nilsson
2015-02-20 0:27 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220002755.GA11399@axis.com \
--to=jesper.nilsson@axis.com \
--cc=jespern@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.