All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Pilon <alp@alexpilon.ca>
To: Jonathon Reinhart <jonathon.reinhart@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Allow specifying bridge port STP state by name rather than number.
Date: Thu, 19 Feb 2015 23:57:30 -0500	[thread overview]
Message-ID: <20150220045730.GA7936@alexpilon.ca> (raw)
In-Reply-To: <CAPFHKzcOFQCtz0pwLm8XOZxTOkC9w4CFq2vcLnwxUfVVmWdNCw@mail.gmail.com>

On Thu, Feb 19, 2015 at 09:00:23PM -0500, Jonathon Reinhart wrote:
> Please don't pass -1 to exit().  It is outside the acceptable range (0 to 255)
> of exit status values:
>
> https://www.gnu.org/software/libc/manual/html_node/Exit-Status.html
>
> Most programs exit(1) when presented with invalid user input.

I was being consistent with nearby code, and the dominant style.  But if
that's the case, then there's a few hundred such mistakes that need
correcting.  Should I fix all of them, and if so, should that be a
single patch, or multiple?

There's also only a few instances of EXIT_{SUCCESS,FAILURE}, so I took
it wasn't the style to use that.

Regards,

Alex Pilon

  reply	other threads:[~2015-02-20  5:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 19:27 [PATCH] Allow specifying bridge port STP state by name rather than number Alex Pilon
2015-02-20  2:00 ` Jonathon Reinhart
2015-02-20  4:57   ` Alex Pilon [this message]
2015-02-20 14:40     ` Jonathon Reinhart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150220045730.GA7936@alexpilon.ca \
    --to=alp@alexpilon.ca \
    --cc=jonathon.reinhart@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.