From: Thomas Graf <tgraf@suug.ch>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: davem@davemloft.net, johunt@akamai.com, netdev@vger.kernel.org
Subject: Re: [PATCH net 3/3] rhashtable: allow to unload test module
Date: Fri, 20 Feb 2015 12:01:52 +0000 [thread overview]
Message-ID: <20150220120152.GD4586@casper.infradead.org> (raw)
In-Reply-To: <c0c78ef9a196812dc8a2922bb2a957a04c6dbfb6.1424389682.git.daniel@iogearbox.net>
On 02/20/15 at 12:53am, Daniel Borkmann wrote:
> There's no good reason why to disallow unloading of the rhashtable
> test case module.
>
> Commit 9d6dbe1bbaf8 moved the code from a boot test into a stand-alone
> module, but only converted the subsys_initcall() handler into a
> module_init() function without a related exit handler, and thus
> preventing the test module from unloading.
>
> Fixes: 9d6dbe1bbaf8 ("rhashtable: Make selftest modular")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2015-02-20 12:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 23:53 [PATCH net 0/3] rhashtable updates Daniel Borkmann
2015-02-19 23:53 ` [PATCH net 1/3] rhashtable: don't test for shrink on insert, expansion on delete Daniel Borkmann
2015-02-20 10:08 ` David Laight
2015-02-20 10:13 ` Daniel Borkmann
2015-02-20 11:56 ` tgraf
2015-02-20 11:59 ` Thomas Graf
2015-02-19 23:53 ` [PATCH net 2/3] rhashtable: better high order allocation attempts Daniel Borkmann
2015-02-20 10:11 ` David Laight
2015-02-20 10:23 ` Daniel Borkmann
2015-02-20 13:46 ` Eric Dumazet
2015-02-20 14:27 ` David Laight
2015-02-20 14:31 ` tgraf
2015-02-20 14:58 ` Eric Dumazet
2015-02-20 14:54 ` Eric Dumazet
2015-02-20 12:01 ` Thomas Graf
2015-02-19 23:53 ` [PATCH net 3/3] rhashtable: allow to unload test module Daniel Borkmann
2015-02-20 12:01 ` Thomas Graf [this message]
2015-02-20 22:38 ` [PATCH net 0/3] rhashtable updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220120152.GD4586@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=johunt@akamai.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.