From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Matthew Garrett <matthew.garrett@nebula.com>,
stable@vger.kernel.org
Subject: Re: [RFT PATCH v3 1/2] compal-laptop: Fix leaking hwmon device
Date: Fri, 20 Feb 2015 08:50:28 -0800 [thread overview]
Message-ID: <20150220165028.GD22752@roeck-us.net> (raw)
In-Reply-To: <1424438015-3006-1-git-send-email-k.kozlowski@samsung.com>
On Fri, Feb 20, 2015 at 02:13:34PM +0100, Krzysztof Kozlowski wrote:
> The commit c2be45f09bb0 ("compal-laptop: Use
> devm_hwmon_device_register_with_groups") wanted to change the
> registering of hwmon device to resource-managed version. It mostly did
> it except the main thing - it forgot to use devm-like function so the
> hwmon device leaked after device removal or probe failure.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Fixes: c2be45f09bb0 ("compal-laptop: Use devm_hwmon_device_register_with_groups")
> Cc: <stable@vger.kernel.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Guenter
next prev parent reply other threads:[~2015-02-20 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 13:13 [RFT PATCH v3 1/2] compal-laptop: Fix leaking hwmon device Krzysztof Kozlowski
2015-02-20 13:13 ` [RFT PATCH v3 2/2] compal-laptop: Check return value of power_supply_register Krzysztof Kozlowski
2015-03-03 16:43 ` Darren Hart
2015-02-20 16:50 ` Guenter Roeck [this message]
2015-03-03 16:42 ` [RFT PATCH v3 1/2] compal-laptop: Fix leaking hwmon device Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220165028.GD22752@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cezary.jackiewicz@gmail.com \
--cc=dvhart@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.