From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/7] libsigrok: enable building C++ bindings
Date: Fri, 20 Feb 2015 19:30:35 +0100 [thread overview]
Message-ID: <20150220193035.7f90d46f@free-electrons.com> (raw)
In-Reply-To: <1424435342-2188-7-git-send-email-bgolaszewski@baylibre.com>
Dear Bartosz Golaszewski,
On Fri, 20 Feb 2015 13:29:01 +0100, Bartosz Golaszewski wrote:
> +config BR2_PACKAGE_LIBSIGROKCXX
> + bool "build C++ bindings"
> + select BR2_PACKAGE_GLIBMM
> + depends on BR2_PACKAGE_LIBSIGROK
> + depends on BR2_TOOLCHAIN_BUILDROOT_CXX
> + # C++11 support
> + depends on BR2_TOOLCHAIN_BUILDROOT_GLIBC || BR2_TOOLCHAIN_BUILDROOT_EGLIBC
I am not really happy with this, because there are potentially plenty
of external toolchains that support C++11. So I believe we really need
to go ahead and add a:
BR2_TOOLCHAIN_HAS_CXX11
And make sure it gets properly selected depending on whether the
toolchain has C++11 support or not. You can look at how
BR2_TOOLCHAIN_HAS_SSP or BR2_TOOLCHAIN_HAS_THREADS are implemented for
example.
Moreover, you make this apparently depend on the selected C library.
But isn't C++11 support purely a gcc problem ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-02-20 18:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 12:28 [Buildroot] [PATCH 0/7] sigrok fixes and pulseview package Bartosz Golaszewski
2015-02-20 12:28 ` [Buildroot] [PATCH 1/7] libsigrok: remove --disable-udev from CONF_OPTS Bartosz Golaszewski
2015-02-20 12:28 ` [Buildroot] [PATCH 2/7] libserialport: drop untrue statement from Config.in help Bartosz Golaszewski
2015-02-20 12:28 ` [Buildroot] [PATCH 3/7] libsigrok: don't select libserialport in Config.in Bartosz Golaszewski
2015-02-20 12:28 ` [Buildroot] [PATCH 4/7] autoconf-archive: new package Bartosz Golaszewski
2015-02-20 18:28 ` Thomas Petazzoni
2015-02-20 12:29 ` [Buildroot] [PATCH 5/7] libsigrok: bump git commit tag Bartosz Golaszewski
2015-02-20 12:29 ` [Buildroot] [PATCH 6/7] libsigrok: enable building C++ bindings Bartosz Golaszewski
2015-02-20 18:30 ` Thomas Petazzoni [this message]
2015-02-23 11:23 ` Nicolas Cavallari
2015-02-20 12:29 ` [Buildroot] [PATCH 7/7] pulseview: new package Bartosz Golaszewski
2015-02-20 18:15 ` [Buildroot] [PATCH 0/7] sigrok fixes and pulseview package Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220193035.7f90d46f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.