All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Joel Schopp <joel.schopp@amd.com>
Cc: Gleb Natapov <gleb@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: svm: use kvm_register_write()/read()
Date: Fri, 20 Feb 2015 21:54:29 +0100	[thread overview]
Message-ID: <20150220205429.GC19589@pd.tnic> (raw)
In-Reply-To: <20150220183939.16805.54776.stgit@joelvmguard2.amd.com>

On Fri, Feb 20, 2015 at 12:39:40PM -0600, Joel Schopp wrote:
> KVM has nice wrappers to access the register values, clean up a few places
> that should use them but currently do not.
> 
> Signed-off-by:David Kaplan <david.kaplan@amd.com>
> Signed-off-by:Joel Schopp <joel.schopp@amd.com>

This SOB chain looks strange. If David is the author, you want to have
him in From: at the beginning of the patch.

Stuff you did ontop should be in []-braces before your SOB, like this:

Signed-off-by: David Kaplan <david.kaplan@amd.com>
[ Did this and that to patch. ]
Signed-off-by: Joel Schopp <joel.schopp@amd.com>

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

  reply	other threads:[~2015-02-20 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 18:39 [PATCH] x86: svm: use kvm_register_write()/read() Joel Schopp
2015-02-20 20:54 ` Borislav Petkov [this message]
2015-02-20 21:44   ` Joel Schopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150220205429.GC19589@pd.tnic \
    --to=bp@alien8.de \
    --cc=gleb@kernel.org \
    --cc=joel.schopp@amd.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.